Bug #81343 [Opn->Csd]: pdo_pgsql: Inconsitent boolean conversion after calling closeCursor()
Edit report at https://bugs.php.net/bug.php?id=81343&edit=1
ID: 81343
Updated by: git@php.net
Reported by: phofstetter at sensational dot ch
Summary: pdo_pgsql: Inconsitent boolean conversion after
calling closeCursor()
-Status: Open
+Status: Closed
Type: Bug
Package: PDO PgSQL
Operating System: macOS
PHP Version: 8.1.0beta2
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of pilif (author) and nikic (committer)
Revision: https://github.com/php/php-src/commit/ace8fba759f54c9be128321dd2153778fb3d457e
Log: Fix bug #81343: inconsistent type conversion after closeCursor
Previous Comments:
------------------------------------------------------------------------
[2021-08-10 13:34:48] phofstetter at sensational dot ch
I have attached a PR that fixes the problem, though I would love to get a review by Nikita who did
the big PDO result refactoring.
I'm not entirely sure it's safe to not free S->cols, but reading the code, I believe
cols is freed in the statement destructor anyways.
The other approach would be to restore the freeing of the column metadata and call
describe again on subsequent execs
------------------------------------------------------------------------
[2021-08-10 13:32:34] phofstetter at sensational dot ch
The following pull request has been associated:
Patch Name: fix bug 81343: inconsistent type conversion after closeCursor
On GitHub: https://github.com/php/php-src/pull/7355
Patch: https://github.com/php/php-src/pull/7355.patch
------------------------------------------------------------------------
[2021-08-10 13:03:37] phofstetter at sensational dot ch
According to git bisect, commit caa710037e663fd78f67533b29611183090068b2 is where this broke.
> Rewrite PDO result binding
commit subject checks out :p
------------------------------------------------------------------------
[2021-08-10 12:09:17] phofstetter at sensational dot ch
Description:
------------
After calling closeCursor() on a Postgres PDO statement handle, the conversion behavior for boolean
values will change:
prior to calling closeCursor, boolean values in the database get converted to PHP boolean values.
after calling closeCursor() (and subsequently calling execute() again), boolean values will be
converted to strings 't' and 'f'
This was fine in PHP 8.0, broken in PHP 8.1b2 at least, though I'll update this bug with after
some bisecting to find the specific commit.
Test script:
---------------
$pdo = new PDO('pgsql:host=localhost;port=5432;user=someuser;dbname=somedb');
$sth = $pdo->prepare("select false where 2=?");
for ($i = 0; $i < 2; $i++) {
$sth->execute([2]);
var_dump($sth->fetchColumn(0));
$sth->closeCursor();
}
Expected result:
----------------
bool(false)
bool(false)
Actual result:
--------------
bool(false)
string(1) "f"
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=81343&edit=1
Thread (5 messages)