Bug #81433 [Opn->Csd]: DOMElement::setIdAttribute(attr, true) called twice removes ID

Edit report at https://bugs.php.net/bug.php?id=81433&edit=1 ID: 81433 Updated by: git@php.net Reported by: vv_volkov at mail dot ru Summary: DOMElement::setIdAttribute(attr, true) called twice removes ID -Status: Open +Status: Closed Type: Bug Package: DOM XML related PHP Version: 7.4.23 Block user comment: N Private report: N New Comment: Automatic comment on behalf of vicvolk (author) and cmb69 (committer) Revision: https://github.com/php/php-src/commit/424c2654780b7d216abfc5eef37b8d73f1fe5df4 Log: Fix #81433: DOMElement::setIdAttribute() called twice may remove ID Previous Comments: ------------------------------------------------------------------------ [2021-09-13 08:20:59] cmb@php.net The following pull request has been associated: Patch Name: fix(php_set_attribute_id): fix incorrect ID removal, when is_id == 1 On GitHub: https://github.com/php/php-src/pull/7482 Patch: https://github.com/php/php-src/pull/7482.patch ------------------------------------------------------------------------ [2021-09-13 05:51:10] vv_volkov at mail dot ru Description: ------------ The method DOMElement::setIdAttribute(attr, true) works incorrectly. When called twice, it removes identity from the attribute. This pull request - https://github.com/php/php-src/pull/7482 - contains the bug fix Test script: --------------- $dom = new DOMDocument('1.0', 'utf-8'); $element = $dom->createElement('test', 'root'); $dom->appendChild($element); $element->setAttribute("id", 123); $element->setIdAttribute("id", true); $node = $element->getAttributeNode("id"); echo $node->isId(), "\n"; $element->setIdAttribute("id", true); echo $node->isId(), "\n"; Expected result: ---------------- The second call must not remove ID from the attribute Actual result: -------------- ID is removed from the attribute ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=81433&edit=1