Bug #73062 [Fbk->Csd]: Test for -fvisibility=hidden support fails with certain $CC
| From: | cmb@php.net | Date: | Tue, 05 Oct 2021 15:15:32 +0000 |
| Subject: | Bug #73062 [Fbk->Csd]: Test for -fvisibility=hidden support fails with certain $CC | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-237051@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=73062&edit=1
ID: 73062
Updated by: cmb@php.net
Reported by: michael at orlitzky dot com
Summary: Test for -fvisibility=hidden support fails with
certain $CC
-Status: Feedback
+Status: Closed
Type: Bug
Package: *Compile Issues
PHP Version: 7.1Git-2016-09-10 (Git)
Assigned To: cmb
Block user comment: N
Private report: N
Previous Comments:
------------------------------------------------------------------------
[2021-10-05 15:03:03] michael at orlitzky dot com
It's fixed. Thanks!
------------------------------------------------------------------------
[2021-10-05 14:25:08] cmb@php.net
Michael's PR had been merged, so I think this issue is resolved.
Or are there still issues with any of the actively supported PHP
versions[1]?
[1] <https://www.php.net/supported-versions.php>
------------------------------------------------------------------------
[2018-02-14 14:03:24] michael at orlitzky dot com
> The current test in php-7.2.2 gives a false pass (aka yes) when the compile is done with -c.
> Without -c the flag fails.
Is that causing a problem building PHP? I'm not familiar with xlc, but Google tells me that
"-c" means "don't link," so the build should fail anyway with
"-c" in your CFLAGS.
In any case, the macro is only supposed to check whether or not "-fvisibility=hidden"
works with your current CC/CFLAGS. If you have CFLAGS="-c" and if the test (incorrectly)
passes, that should still be ok since everything will be compiled with "-c
-fvisibility=hidden". Unless it isn't; like I said I don't know anything about xlc =)
------------------------------------------------------------------------
[2018-02-13 20:37:54] aixtools at felt dot demon dot nl
FYI.
The current test in php-7.2.2 gives a false pass (aka yes) when the compile is done with -c. Without
-c the flag fails.
System AIX, complier xlc
root@x065:[/data/prj/php/php-7.2.2]xlc_r -c -I/opt/include -I/opt/include/mysql -qmaxmem=-1
-qarch=pwr5 -fvisibility=hidden -I/opt/include x.c
root@x065:[/data/prj/php/php-7.2.2]xlc_r -I/opt/include -I/opt/include/mysql -qmaxmem=-1 -qarch=pwr5
-fvisibility=hidden -I/opt/include x.c
ld: 0706-005 Cannot find or open file: visibility=hidden
ld:fopen(): A file or directory in the path name does not exist.
------------------------------------------------------------------------
[2016-09-10 22:58:01] michael at orlitzky dot com
Good idea =)
https://github.com/php/php-src/pull/2124
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=73062
--
Edit this bug report at https://bugs.php.net/bug.php?id=73062&edit=1