Bug #68786 [Opn]: Missing check
Edit report at https://bugs.php.net/bug.php?id=68786&edit=1
ID: 68786
Updated by: cmb@php.net
Reported by: bugreports at internot dot info
Summary: Missing check
Status: Open
Type: Bug
-Package: *General Issues
+Package: Scripting Engine problem
Operating System: Linux Ubuntu 14.04
PHP Version: master-Git-2015-01-10 (Git)
Block user comment: N
Private report: N
New Comment:
While It might be okay not to check the return value on getting[1]
(it is certainly important on setting), it might still be prudent
to do so.
[1] <https://github.com/php/php-src/blob/php-7.4.24/Zend/zend_signal.c#L348>
Previous Comments:
------------------------------------------------------------------------
[2015-01-10 10:19:49] bugreports at internot dot info
Description:
------------
Hi,
In Zend/zend_signal.c:
Zend/zend_signal.c:306: sigaction(zend_sigs[x], NULL, &sa);
Zend/zend_signal.c-307- if (sa.sa_sigaction != zend_signal_handler_defer) {
Zend/zend_signal.c-308- zend_error(E_CORE_WARNING, "zend_signal:
handler was replaced for signal (%d) after startup", zend_sigs[x]);
Zend/zend_signal.c-309- }
The return value of "sigaction(zend_sigs[x], NULL, &sa)" is not checked, as it is
everywhere else it is used.
It should be checked here, too.
Thanks,
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=68786&edit=1
Thread (2 messages)