Bug #81543 [PATCH]: parse_url omits leading slash in windows paths

Edit report at https://bugs.php.net/bug.php?id=81543&edit=1 ID: 81543 Patch added by: sample@email.tst Reported by: ppchelko at wikimedia dot org Summary: parse_url omits leading slash in windows paths Status: Open Type: Bug Package: *URL Functions Operating System: Any PHP Version: master-Git-2021-10-19 (Git) Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: HcPcEgmp Revision: 1635653576 URL: https://bugs.php.net/patch-display.php?bug=81543&patch=HcPcEgmp&revision=1635653576 Previous Comments: ------------------------------------------------------------------------ [2021-10-31 04:12:53] sample at email dot tst The following patch has been added/updated: Patch Name: HcPcEgmp Revision: 1635653573 URL: https://bugs.php.net/patch-display.php?bug=81543&patch=HcPcEgmp&revision=1635653573 ------------------------------------------------------------------------ [2021-10-31 04:12:51] sample at email dot tst The following patch has been added/updated: Patch Name: HcPcEgmp Revision: 1635653571 URL: https://bugs.php.net/patch-display.php?bug=81543&patch=HcPcEgmp&revision=1635653571 ------------------------------------------------------------------------ [2021-10-31 04:12:47] sample at email dot tst The following patch has been added/updated: Patch Name: HcPcEgmp Revision: 1635653567 URL: https://bugs.php.net/patch-display.php?bug=81543&patch=HcPcEgmp&revision=1635653567 ------------------------------------------------------------------------ [2021-10-20 14:37:28] ppchelko at wikimedia dot org The following pull request has been associated: Patch Name: Fix #81543: parse_url omits leading slash in windows paths On GitHub: https://github.com/php/php-src/pull/7598 Patch: https://github.com/php/php-src/pull/7598.patch ------------------------------------------------------------------------ [2021-10-20 08:23:56] cmb@php.net The commit[1] that would be effectively reverted by your patch, deliberately removes the leading slash of the path. While this is wrong, and URIs like file://localhost/c:/ are treated differently, I don't think we should fix this for any of the stable branches (probably not even for PHP 8.1) for BC reasons. Anyhow, I (generally) recommend to submit pull requests[2] instead of attaching patches to the bug tracker for better visibility and discussability. [1] <https://github.com/php/php-src/commit/4505a611ba8cdcc08505a5ffa0e35bda385bd374> [2] <https://github.com/php/php-src/pulls> ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=81543 -- Edit this bug report at https://bugs.php.net/bug.php?id=81543&edit=1