Bug #81632 [Asn->Csd]: Shuffled parser tokens on PHP 8.1?
Edit report at https://bugs.php.net/bug.php?id=81632&edit=1
ID: 81632
User updated by: ondrej at mirtes dot cz
Reported by: ondrej at mirtes dot cz
Summary: Shuffled parser tokens on PHP 8.1?
-Status: Assigned
+Status: Closed
Type: Bug
Package: *General Issues
Operating System: Ubuntu
PHP Version: 8.1Git-2021-11-17 (Git)
Assigned To: cmb
Block user comment: N
Private report: N
New Comment:
The problem was in ext-ds: https://github.com/shivammathur/setup-php/issues/527#issuecomment-972558744
Previous Comments:
------------------------------------------------------------------------
[2021-11-17 21:10:37] ondrej at mirtes dot cz
I just tried reproducing it on a simple example and couldn't, it works as expected, even in
GitHub Actions: https://github.com/ondrejmirtes/php-bug-81632/actions/runs/1473635299
(the failures on pre-7.4 are because of typed properties)
So to me it looks like some stateful thing where a series of actions corrupts how token_get_all
behaves.
------------------------------------------------------------------------
[2021-11-17 18:57:52] cmb@php.net
https://bugs.php.net/bug.php?id=81632
Right, c02aa461268843270a6897c20ef3fb4b00d9de8a is on PHP-8.1, but
not on master (it had been merged into master, though). I have
been fooled by GH UI (I thought that had been fixed some time
ago).
Anyhow, I did a fresh build of that commit, and got the expected
results. I have no idea what might be wrong.
------------------------------------------------------------------------
[2021-11-17 18:14:24] contact at shivammathur dot com
I have rechecked that correct branches are used.
c02aa461268843270a6897c20ef3fb4b00d9de8a is also in PHP-8.1
$ git branch -a --contains c02aa461268843270a6897c20ef3fb4b00d9de8a
* master
remotes/origin/HEAD -> origin/master
remotes/origin/PHP-8.1
remotes/origin/master
------------------------------------------------------------------------
[2021-11-17 16:50:28] cmb@php.net
It seems <https://github.com/shivammathur/setup-php/issues/527>
is back. <https://github.com/phpstan/phpstan-src/runs/4240473383?check_suite_focus=true#step:3:13>
mentions commit c02aa461268843270a6897c20ef3fb4b00d9de8a, but that appears to be on master, not on
PHP 8.1.
------------------------------------------------------------------------
[2021-11-17 16:28:26] ondrej at mirtes dot cz
This is the debug code that outputs the log: https://github.com/phpstan/phpstan-src/blob/ec1ea7c50bcc35d9506e86746a0a2f46171599e7/NetteReflection.php#L307
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=81632
--
Edit this bug report at https://bugs.php.net/bug.php?id=81632&edit=1
Thread (9 messages)