Bug #40683 [Com]: zend_operators.h generates discard qualifier compiler warning

Edit report at https://bugs.php.net/bug.php?id=40683&edit=1 ID: 40683 Comment by: dennis dot buteyn at xorcom dot com Reported by: lstefani at fortresstech dot com Summary: zend_operators.h generates discard qualifier compiler warning Status: Wont fix Type: Bug Package: Compile Warning Operating System: linux 2.6.12-1.1381_FC3smp PHP Version: 5.2.1 Block user comment: N Private report: N New Comment: Would like someone to reopen this bug if possible, it is preventing me from using -Werror compiler flag. Have seen this warning while compiling for both PHP 5 and PHP 7 without fail. Here is part of the build log when cross-compiling to arm64 in a Debian 11 Docker container. libtool: compile: aarch64-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I./include -Wall -Wextra -Wshadow -pedantic -fPIC -fno-rtti -std=c++14 -flto -ffunction-sections -fdata-sections -g -I/usr/include/php/20190902 -I/usr/include/php/20190902/main -I/usr/include/php/20190902/TSRM -I/usr/include/php/20190902/Zend -I/usr/include/php/20190902/ext -I/usr/include/php/20190902/ext/date/lib -Wno-unused -Wno-unused-parameter -c plugin.cpp -fPIC -DPIC -o src/.libs/plugin.o In file included from /usr/include/php/20190902/Zend/zend.h:356, from /usr/include/php/20190902/main/php.h:34, from src/ombu_xlic.cpp:2: /usr/include/php/20190902/Zend/zend_operators.h: In function 'const void* zend_memrchr(const void*, int, size_t)': /usr/include/php/20190902/Zend/zend_operators.h:197:13: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] 197 | if (*e == (const unsigned char)c) { | ^~~~~~~~~~~~~~~~~~~~~~ Previous Comments: ------------------------------------------------------------------------ [2007-03-12 09:29:08] tony2001@php.net You can safely ignore it. And no, I can't reproduce this warning with GCC4 & GCC3.4.6 or any other compiler. ------------------------------------------------------------------------ [2007-03-12 00:08:58] lstefani at fortresstech dot com Sorry for the late response. Your email hit my company spam filter for some reason. Just found it while going through the bulk mail folder. To answer your question, I'm using the MIPS cross-compiler (GCC 3.3.2 and GLIBC 2.3.2) on Linux x86. I know that's not the latest GCC compiler by a long shot, but just from reviewing the code, it does appear that the const declaration is being discarded by recasting the parameter as an unsigned char. ------------------------------------------------------------------------ [2007-03-09 01:00:01] php-bugs at lists dot php dot net No feedback was provided for this bug for over a week, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open". ------------------------------------------------------------------------ [2007-03-01 19:59:07] tony2001@php.net What compiler do you use? ------------------------------------------------------------------------ [2007-03-01 19:44:25] lstefani at fortresstech dot com Description: ------------ Zend/zend_operators.h: In function `void* zend_memrchr(const void*, int, unsigned int)': Zend/zend_operators.h:250: warning: cast from const void*' to unsigned char*' discards qualifiers from pointer target type Zend/zend_operators.h:250: warning: cast from const void*' to unsigned char*' discards qualifiers from pointer target type In code snippet, line 250 refers to the two recasts of argument s. Reproduce code: --------------- static inline void *zend_memrchr(const void *s, int c, size_t n) { register unsigned char *e; if (n <= 0) { return NULL; } for (e = (unsigned char *)s + n - 1; e >= (unsigned char *)s; e--) { if (*e == (unsigned char)c) { return (void *)e; } } return NULL; } Expected result: ---------------- No compiler warnings. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=40683&edit=1