Req #62630 [Opn]: issues with starting FPM in conditions of high load

Edit report at https://bugs.php.net/bug.php?id=62630&edit=1 ID: 62630 Updated by: bukka@php.net Reported by: christian dot lawrence at calorieking dot com Summary: issues with starting FPM in conditions of high load Status: Open Type: Feature/Change Request Package: FPM related PHP Version: 5.4.5 -Assigned To: +Assigned To: bukka Block user comment: N Private report: N New Comment: Apology for very long delay. I'm just going through the bugs and there are some good points in here. Mainly I see the point about a need to set pm.start_servers to more than pm.max_spare_servers. However to make it work I think it will be necessary to introduce an option for the startup period when pm.max_spare_servers is not considered. I think the 2nd point about pm.min_spare_servers makes sense too. Changing default is a bit harder though as there might be some configurations relaying on it but might need to think about it. Also there's a new feature in PHP 8.1 that improves situation for spawning rate. There's now a new option pm.max_spawn_rate which allows to make spawning much faster. More info here: https://github.com/php/php-src/pull/6753 . Previous Comments: ------------------------------------------------------------------------ [2012-07-21 11:20:57] christian dot lawrence at calorieking dot com Description: ------------ We had to start our FPM service during peak time, so traffic to the website was already heavily loaded. The FPM service is configured for pm = dynamic. To take the initial spike in load off the FPM service we tried to inflate pm.start_servers only to discover that we can not set it higher than the value of the pm.max_spare_servers setting. The pm.max_spare_servers setting essentially defines the maximum number of idle children in the pool, which when exceeded, FPM will kill off idle children starting with the oldest first at a rate of one every second. The reasoning is unclear why pm.start_servers should be possibly constrained by such an "idle" pool size in the first place? Pressing on, we also discovered issues with the pm.min_spare_servers setting, which essentially defines the number of additional spare children to spawn when the number of idle children in the pool drops below this value. This value can not be set higher than pm.max_spare_servers. Again, the reasoning behind this is unclear? If pm.min_spare_servers is set to the same value as pm.max_spare_servers then this means that the pool size can only grow in multiples of pm.max_spare_servers or fewer. Or so we thought... It turns out that FPM is hard-coded to spawn no more than 32 children per second only if pm.min_spare_servers is set to any value higher than 32. As an extreme case, assume for the moment pm.max_children to be 256 and there are 0 idle children at any point in time. With pm.min_spare_servers set to a value higher than 32 and pm.start_servers and pm.max_spare_servers both set to 32, then starting FPM would take an additional 7 seconds to spin up to maximum capacity. Raising pm.max_spare_servers and hence pm.start_servers helps to reduce the spin up time, but involves another reconfiguration and restart during offpeak time to restore the original configuration. To avoid such a costly spin up time under high load conditions followed by an unnecessary reconfiguration later, it is beneficial to initially start a high number of children with a slow kill off of excess idle children when demand recedes, rather than a slow ramp up of children to meet the demand. I propose the following changes be made: 1. The configuration constraint for pm.start_servers be replaced with it having a value between 1 and pm.max_children inclusive and not a value between pm.min_spare_servers and pm.max_spare_servers inclusive (the notion of pm.min_spare_servers as a lower constraint for pm.start_servers is nonsensical). 2. The configuration constraint for pm.min_spare_servers be replaced with it having a value between 1 and (pm.max_children - pm.max_spare_servers) inclusive. If this value is 0, then there will be no growth in pool size (c.f.: pm = static). 3. The default value for pm.start_servers be changed from (pm.min_spare_servers + ((pm.max_spare_servers - pm.min_spare_servers)/2)) to (pm.max_spare_servers + pm.min_spare_servers). 4. The configuration documentation and the manual for FPM be updated to take note of the above changes. 5. Update the manual that the fact that FPM will spawn additional spare children at a rate of no more than 32 children/second and kill of idle children at a rate of 1 child/second. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=62630&edit=1