[php-src] Issue #7995: Clean up ext/com_dotnet/com_handlers.c
| From: | RyanNerd | Date: | Mon, 24 Jan 2022 04:19:31 +0000 |
| Subject: | [php-src] Issue #7995: Clean up ext/com_dotnet/com_handlers.c | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-239271@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/7995
Author: RyanNerd
### Description
There are 4 TODO items in the code. Putting this here to get this on the radar to either fix or
wontfix (in the case of wontfix the todos should be removed from the codebase). The file isn't
very large so a copy/paste of the relevant code is below. The only other file that seems to make
reference to com_handlers.c is com_variant.c
Side note: The entire handling of PHP variant / COM types seems very clunky to me. But I've not
dealt with Windows COM in years so maybe it is the way it is.
```c
static int com_property_exists(zend_object *object, zend_string *member, int check_empty, void
**cache_slot)
{
DISPID dispid;
php_com_dotnet_object *obj;
obj = (php_com_dotnet_object*) object;
if (V_VT(&obj->v) == VT_DISPATCH) {
if (SUCCEEDED(php_com_get_id_of_name(obj, member, &dispid))) {
/* TODO: distinguish between property and method! */
return 1;
}
} else {
/* TODO: check for safearray */
}
return 0;
}
static int com_dimension_exists(zend_object *object, zval *member, int check_empty)
{
/* TODO Add support */
zend_throw_error(NULL, "Cannot check dimension on a COM object");
return 0;
}
static void com_property_delete(zend_object *object, zend_string *member, void **cache_slot)
{
zend_throw_error(NULL, "Cannot delete properties from a COM object");
}
static void com_dimension_delete(zend_object *object, zval *offset)
{
zend_throw_error(NULL, "Cannot delete dimension from a COM object");
}
static HashTable *com_properties_get(zend_object *object)
{
/* TODO: use type-info to get all the names and values ?
* DANGER: if we do that, there is a strong possibility for
* infinite recursion when the hash is displayed via var_dump().
* Perhaps it is best to leave it un-implemented.
*/
return (HashTable *) &zend_empty_array;
}
```