Bug #76109 [Opn->Csd]: Unsafe access to fpm scoreboard
Edit report at https://bugs.php.net/bug.php?id=76109&edit=1
ID: 76109
Updated by: git@php.net
Reported by: backhaus at traum-ferienwohnungen dot de
Summary: Unsafe access to fpm scoreboard
-Status: Open
+Status: Closed
Type: Bug
Package: FPM related
Operating System: Linux
PHP Version: PHP-7.1
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of (author) and bukka (committer)
Revision: https://github.com/php/php-src/commit/29fe06fa5919bb0f239677d29f3856d64537eeec
Log: Fix bug #76109: Implement fpm_scoreboard_copy
Previous Comments:
------------------------------------------------------------------------
[2018-06-10 15:54:49] cmb@php.net
Changing PHP version to match the PR.
------------------------------------------------------------------------
[2018-03-29 08:37:38] backhaus at traum-ferienwohnungen dot de
Actually it's not 3185 again, it's https://github.com/php/php-src/pull/3188 now.
------------------------------------------------------------------------
[2018-03-29 08:36:25] backhaus at traum-ferienwohnungen dot de
Pull request is https://github.com/php/php-src/pull/3185
------------------------------------------------------------------------
[2018-03-17 19:38:54] backhaus at traum-ferienwohnungen dot de
Pull request is https://github.com/php/php-src/pull/3185. Cannot
attach because the bug tracker cannot load it from github for some reason.
------------------------------------------------------------------------
[2018-03-17 13:59:58] backhaus at traum-ferienwohnungen dot de
Description:
------------
It seems there is an unsafe access to the scoreboard procs in fpm_status_handle_request. The
scoreboard is copied under a lock, but later scoreboard procs are copied from scoreboard_p without
locking.
This was pointed out to me by bukka in https://github.com/php/php-src/pull/3182#discussion_r174150992
.
The risk of this is pretty low. The only impact in can imagine being inconsistent readings on the
status page.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=76109&edit=1
Thread (6 messages)