[php-src] Issue #7992: Unify dns_*() function definitions for all platforms

Issue: https://github.com/php/php-src/issues/7992 Comment Author: pierrejoye > This comment confuses me. The implementation of the > gethostby*() function looks reasonable; the implementation of the > dns_*() functions appears to be the actual issue, since back then > they have been implemented in dns_win32.c as full PHP functions, > which already caused issues, It does not for 13 years. This was the only to have clean codes somehow without massive functions full of #ifdef. For what I see, the culprit is the change from getaddrinfo to getnameinfo for php_getaddrinfo, both functions do not behave the same and do not aim for the same features. Let see why it was changed then we can advise about the best fix :) > because it's indeed easily overlooked that their implementation in > dns.c is not the only one available. Improving this makes sense to > me.