[php-src] Issue #8113: Php crashing with a TypeError even when declare(strict_types=1) is not set, or even set to strict_types=0
| From: | KapitanOczywisty | Date: | Fri, 18 Feb 2022 11:55:48 +0000 |
| Subject: | [php-src] Issue #8113: Php crashing with a TypeError even when declare(strict_types=1) is not set, or even set to strict_types=0 | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-239874@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/8113
Comment Author: KapitanOczywisty
From what I remember from making socket server, socket/resource is closed only when explicitly
closed using
socket_close and there is no instance when broken connection causes this
error. What is more important when e.g. remote host disconnects, socket_select will
return immediately. Thus there is absolutely no reason to keep closed socket around even if
socket_select would accept that. Removing socket from $read should follow
any socket_close.
Before 8.0 $read = array_filter($read, 'is_resource') would be sufficient,
but I have no idea how to cleanly check that in the current version.