[php-src] Issue #8308: The return value of mb_list_encodings() doesn't contain 'SJIS-win'
| From: | alexdowad | Date: | Thu, 07 Apr 2022 06:09:13 +0000 |
| Subject: | [php-src] Issue #8308: The return value of mb_list_encodings() doesn't contain 'SJIS-win' | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-240723@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/8308
Comment Author: alexdowad
Just did a first draft of the code to reintroduce
SJIS-win (it's just a few
lines). Still need to adjust the unit tests.
I also still need to re-examine the mappings for CP932, confirm if there have been any changes from
legacy mbstring, and if so, raise each one for discussion here.
I think it would be helpful if we can include some explanation of why users might choose to use
CP932 or SJIS-win in the code comments; this would help future maintainers
and developers to understand why the code is the way it is.
@sj-i stated above:
> SJIS-win and CP932 are both
> used in Japan. Some articles recommend one, others recommend another.
I've not yet read through the references provided by @zonuexe on #8281, so maybe this is
already covered there, but can you explain any reasons why one might recommend the use of
CP932, or conversely, might recommend SJIS-win?