Bug #77826 [Opn->Csd]: xdiff_string_bpatch wrong return value on error

Edit report at https://bugs.php.net/bug.php?id=77826&edit=1 ID: 77826 Updated by: remi@php.net Reported by: kentaro at ranvis dot com Summary: xdiff_string_bpatch wrong return value on error -Status: Open +Status: Closed Type: Bug -Package: xdiff +Package: *General Issues PHP Version: Irrelevant -Assigned To: +Assigned To: remi Block user comment: N Private report: N New Comment: Fixed Previous Comments: ------------------------------------------------------------------------ [2019-03-30 06:38:49] The following pull request has been associated: Patch Name: Fixed bug #77826 (xdiff_string_bpatch wrong return value on error). On GitHub: https://github.com/php/pecl-text-xdiff/pull/3 Patch: https://github.com/php/pecl-text-xdiff/pull/3.patch ------------------------------------------------------------------------ [2019-03-30 06:26:27] kentaro at ranvis dot com Description: ------------ xdiff_string_patch()/xdiff_string_bpatch() (PECL xdiff 2.0.1-dev's) doesn't return false as documented when broken input is passed. I will add PR later. Test script: --------------- var_dump(xdiff_string_bpatch('123', '123')); Expected result: ---------------- bool(false) Actual result: -------------- string(0) "" ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=77826&edit=1