Bug #80923 [Csd]: timezonedb does not compile anymore with PHP 5.3.29

Edit report at https://bugs.php.net/bug.php?id=80923&edit=1 ID: 80923 Updated by: derick@php.net Reported by: phpdev at ehrhardt dot nl Summary: timezonedb does not compile anymore with PHP 5.3.29 Status: Closed Type: Bug -Package: timezonedb +Package: *General Issues Operating System: Windows VC9 PHP Version: Irrelevant Assigned To: derick Block user comment: N Private report: N New Comment: PHP 5.3 would not be able to use this new data format, and the package.xml file was wrong. I have now corrected that. Previous Comments: ------------------------------------------------------------------------ [2022-10-19 15:14:47] git@php.net Automatic comment on behalf of derickr Revision: https://github.com/php/pecl-datetime-timezonedb/commit/fb6fbdc87bd579085481f2d61c65a672ae10fe8e Log: Fixed bug #80923: Mark earliest supported version as PHP 5.4 ------------------------------------------------------------------------ [2021-04-01 07:38:09] phpdev at ehrhardt dot nl The minimum PHP version in http://svn.php.net/viewvc/pecl/timezonedb/trunk/package.xml?view=markup still is 5.2.0. Waht is the reason PHP 5.3.29 is excluded now? After adding PHP 5.3.29 to timezonedb.c, it compiled and loaded fine. I did not run the tests though. Are they expected to fail? > #if PHP_VERSION_ID >= 50329 && PHP_VERSION_ID <= 50399 > # define TIMELIB_SUPPORTS_V2DATA > #endif ------------------------------------------------------------------------ [2021-04-01 07:07:48] derick@php.net I thought I had updated that. But it shouldn't have been in a tinezonedb PECL package release at least? ------------------------------------------------------------------------ [2021-03-31 13:07:30] cmb@php.net > but the PECL info still states that timezonedb is for 'PHP 5.2.0 > or newer'. I think that should be fixed in package.xml. ------------------------------------------------------------------------ [2021-03-31 12:50:40] phpdev at ehrhardt dot nl Description: ------------ I regularly recompile PHP 5.3.27 on Windows (VC9) when a dependency has been updated (like Curl). This time the timezonedb extension did not compile anymore. Error: > Your version of timelib does not understand the timzonedb data format, please upgrade This was introduced in this revision: https://svn.php.net/viewvc/pecl/timezonedb/trunk/timezonedb.h?r1=352315&r2=352314&pathrev=352315 PHP 5.4.41 uses exactly the same timelib files on Windows and it still happlly compiled. So I changed https://svn.php.net/viewvc/pecl/timezonedb/trunk/timezonedb.c?view=markup and defined TIMELIB_SUPPORTS_V2DATA for PHP 5.3.27 as well. It compiled and loaded fine after this change. I know PHP 5.3.27 is really old, but the PECL info still states that timezonedb is for 'PHP 5.2.0 or newer'. Test script: --------------- Compile timezonedb with PHP 5.3.27 on Windows. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=80923&edit=1