Bug #77106 [PATCH]: Missing separator between PHP messages

From: Date: Tue, 29 Nov 2022 21:58:08 +0000
Subject: Bug #77106 [PATCH]: Missing separator between PHP messages
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-242980@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=77106&edit=1

 ID:                 77106
 Patch added by:     bukka@php.net
 Reported by:        olafvdspek at gmail dot com
 Summary:            Missing separator between PHP messages
 Status:             Assigned
 Type:               Bug
 Package:            FPM related
 Operating System:   Linux
 PHP Version:        8.0.2
 Assigned To:        bukka
 Block user comment: N
 Private report:     N

 New Comment:

The following pull request has been associated:

Patch Name: Fix bug #77106: Missing separator in FPM FastCGI errors
On GitHub:  https://github.com/php/php-src/pull/10022
Patch:      https://github.com/php/php-src/pull/10022.patch


Previous Comments:
------------------------------------------------------------------------
[2022-11-29 21:56:27] bukka@php.net

I had a proper look into this and it is not possible to separate the messages as requested with a
new line and separate entries. The reason is that the message is actually FastCGI error data (error
stream). It means that server will display it always as a single entry (I tried with nginx as well
as Apache httpd) for each request due to the way how FastCGI works. It means it should stay as a
single line without any new line character.

That said I agree that not having any separator doesn't look very nice and it's not
readable so I went for separating the messages with '; ' which I think look much better.
As it kind of impacts logging message format and it's somewhere between feature and bug fix, I
will target only PHP 8.2.

------------------------------------------------------------------------
[2021-03-21 19:16:28] bukka@php.net

Yeah this is FPM / internal error logging issue related to log collection in master process.
Basically it's using a pipe from child to process its output. If the child send 2 messages that
don't end with a new line at the same time, then it's a single event and master process
cannot do anything about that. We might need to introduce some tweak in the child to maybe
explicitly add a new line for such cases (internal PHP errors).

------------------------------------------------------------------------
[2021-02-23 14:18:56] olafvdspek at gmail dot com

Somebody? ;)

------------------------------------------------------------------------
[2020-12-01 08:23:02] olafvdspek at gmail dot com

-

------------------------------------------------------------------------
[2020-11-17 08:35:04] olafvdspek at gmail dot com

-

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=77106


--
Edit this bug report at https://bugs.php.net/bug.php?id=77106&edit=1


Thread (16 messages)

« previous php.bugs (#242980) next »