Bug #77828 [Com]: SplFileObject::seek problems on custom stream wrappers

Edit report at https://bugs.php.net/bug.php?id=77828&edit=1 ID: 77828 Comment by: gallwaseborg at gmail dot com Reported by: alexey dot khokhryakov at gmail dot com Summary: SplFileObject::seek problems on custom stream wrappers Status: Open Type: Bug Package: SPL related PHP Version: 7.2.16 Block user comment: N Private report: N New Comment: If you truly need to say thank you ! We'd really appreciate and be thankful expecting you leave a decent report on the module page. This is the best procedure for guiding say thank you to this undertaking and sponsorship bundle. (https://www.subwayliveiq.net/)github.com Previous Comments: ------------------------------------------------------------------------ [2019-04-01 08:36:03] requinix@php.net I know it's not correct. I'm saying, you can see the line reading/byte reading behavior if you switch the stream to read lines. There is a bug here. ------------------------------------------------------------------------ [2019-04-01 08:21:36] alexey dot khokhryakov at gmail dot com I tried and I see that my test script works but it breaks SplFileObject::fread() functionality as I said. file_put_contents($tmpFilename = tempnam(sys_get_temp_dir(), 'test'), "one\r\ntwo\r\n"); stream_wrapper_register('foo', FooStreamWrapper::class); $file = new SplFileObject("foo:/{$tmpFilename}", 'r'); var_dump($file->fread($file->getSize())); Expected: string(10) "one two " Actual: string(5) "one " ------------------------------------------------------------------------ [2019-04-01 08:12:40] requinix@php.net Try the change I said, see what happens. ------------------------------------------------------------------------ [2019-04-01 07:38:58] alexey dot khokhryakov at gmail dot com requinix@php.net, I don't think so. If wrapper::stream_read() proxies calls to fgets() then SplFileObject::fread($count) becomes inconsistent because PHP's file wrapper returns $count of data including linebreaks. ------------------------------------------------------------------------ [2019-03-31 23:19:56] requinix@php.net It's not SplFileObject but your stream wrapper. PHP's file wrapper is reading lines, yours is reading bytes. If you edit yours to read lines as well public function stream_read($count) { return fgets($this->r, $count); } then it works as expected. Not sure the best way to fix this. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=77828 -- Edit this bug report at https://bugs.php.net/bug.php?id=77828&edit=1