[php-src] Issue #10376: Add `max_object_properties` parameter for `json_decode()`
| From: | dktapps | Date: | Thu, 19 Jan 2023 02:22:51 +0000 |
| Subject: | [php-src] Issue #10376: Add `max_object_properties` parameter for `json_decode()` | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-243497@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/10376
Author: dktapps
### Description
Currently,
json_decode() is vulnerable to HashTable supercolliding, when integers are
used as property names in assoc mode, or perhaps when strings with some known hashes are used. This
can be trivially exploited to cause major performance issues in applications which accept JSON
payloads from a client.
While this is obviously a tough issue to solve globally, I think allowing users of
json_decode() to limit the max number of object properties would mostly eliminate the
problem for JSON handling, since most use cases should know or be able to predict what the max
reasonable size of an object should be. I think this should probably be fairly easy to implement.
A precedent for this does exist: max_input_vars was implemented to mitigate HashDoS for
query parameters over a decade ago, so I don't think this is a crazy idea.
Disclaimer: I did already report a security issue for this and was told to create a feature request,
so here it is.