Req #79026 [Com]: change EXTRA_VERSION in 7.4 no longer works

From: Date: Fri, 14 Jul 2023 13:54:47 +0000
Subject: Req #79026 [Com]: change EXTRA_VERSION in 7.4 no longer works
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-244965@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=79026&edit=1

 ID:                 79026
 Comment by:         athoscribeiro at gmail dot com
 Reported by:        bugreports at gmail dot com
 Summary:            change EXTRA_VERSION in 7.4 no longer works
 Status:             Open
 Type:               Feature/Change Request
 Package:            *Configuration Issues
 Operating System:   Linux
 PHP Version:        7.4Git-2019-12-24 (Git)
 Block user comment: N
 Private report:     N

 New Comment:

I filed a PR with a fix proposal for this one at https://github.com/php/php-src/pull/11706


Previous Comments:
------------------------------------------------------------------------
[2019-12-24 10:47:17] cmb@php.net

Well, then switching to feature request, since I don't think this
qualifies as bug.

------------------------------------------------------------------------
[2019-12-24 10:40:08] bugreports at gmail dot com

well, i found at least a solutuin which works but it#s somehow hack to begin with wen we have
./configure and need to hack around in files

touch configure.ac
./buildconf --force
# add vendor-suffix to version and replace dev/rc/alpha/beta
sed -i -E
's/EXTRA_VERSION=".*"/EXTRA_VERSION="-%{versionsuffix}-fc%{fedora}"/'
configure
sed -i -E 's/PHP_EXTRA_VERSION=\$4/PHP_EXTRA_VERSION=-%{versionsuffix}-fc%{fedora}/'
configure

------------------------------------------------------------------------
[2019-12-24 10:35:31] cmb@php.net

Wouldn't it be an option for you to adjust the version number in
configure.ac[1] according to your needs?

[1] <https://github.com/php/php-src/blob/php-7.4.1/configure.ac#L20>

------------------------------------------------------------------------
[2019-12-24 08:48:42] bugreports at gmail dot com

Description:
------------
this works "fine" in 7.2/7.3 but no longer with 7.4 to get buildinfos into "php
-v"

sed -i -E
's/EXTRA_VERSION=".*"/EXTRA_VERSION="-%{versionsuffix}-fc%{fedora}"/'
configure

the configure (at least generated with "touch configure.ac; ./buildconf --force" is nearly
100k lines long with 20 or more functions called main which makes it a mess find out what changed

why can't that stuff not just read PHP_EXTRA_VERSION from a environment variable?





------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=79026&edit=1


Thread (6 messages)

« previous php.bugs (#244965) next »