[php-src] Issue #12053: [PDO] Integration of pdo_raise_impl_error and pdo_handle_error, or clear separation

From: Date: Sat, 26 Aug 2023 11:01:54 +0000
Subject: [php-src] Issue #12053: [PDO] Integration of pdo_raise_impl_error and pdo_handle_error, or clear separation
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-245249@lists.php.net to get a copy of this message
Issue: https://github.com/php/php-src/issues/12053 Author: SakiTakamachi ### Description pdo_raise_impl_error: https://github.com/php/php-src/blob/58ae26a2a71e2c747c821b06c1af99805acac233/ext/pdo/pdo_dbh.c#L68 pdo_handle_error: https://github.com/php/php-src/blob/58ae26a2a71e2c747c821b06c1af99805acac233/ext/pdo/pdo_dbh.c#L128 I'm not familiar with the history of these, but they seem to have very similar functionality, at least from looking at the code. Additionally, pdo_raise_impl_error seems to have a known bug that has been neglected for about 19 years. If it doesn't make sense for them to exist separately and independently, I'd like to propose a change that either consolidates functionality or clearly separates roles. It's probably a big change and should be introduced after 8.4 and would require an RFC, but if there's some historical reason I don't know about, then the proposal is moot. That's why I asked the question first. Thank you.

« previous php.bugs (#245249) next »