[php-src] Issue #14109: heap-buffer-overflow with opcache when extending an internal class with class constant attributes

From: Date: Thu, 02 May 2024 11:41:37 +0000
Subject: [php-src] Issue #14109: heap-buffer-overflow with opcache when extending an internal class with class constant attributes
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-246848@lists.php.net to get a copy of this message
Issue: https://github.com/php/php-src/issues/14109 Author: TimWolla ### Description The following code sapi/cli/php -d zend_extension=$(pwd)/modules/opcache.so -d opcache.enable_cli=1 -d opcache.protect_memory=1 test.php ```php <?php class Test extends ZendAttributeTest { } echo "Success"; ?> ``` Resulted in this output: ``` ================================================================= ==759376==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60d000000000 at pc 0x5641f1586a27 bp 0x7ffdd841e720 sp 0x7ffdd841e718 READ of size 8 at 0x60d000000000 thread T0 #0 0x5641f1586a26 in zend_mm_free_heap php-src/Zend/zend_alloc.c:1433:3 #1 0x5641f158c526 in _efree php-src/Zend/zend_alloc.c:2600:2 #2 0x7f199bb6b521 in _zend_shared_memdup php-src/ext/opcache/zend_shared_alloc.c:435:3 #3 0x7f199bb6b596 in zend_shared_memdup_free php-src/ext/opcache/zend_shared_alloc.c:452:9 #4 0x7f199b9e8f50 in zend_hash_persist php-src/ext/opcache/zend_persist.c:125:11 #5 0x7f199b9fa9a9 in zend_persist_attributes php-src/ext/opcache/zend_persist.c:289:2 #6 0x7f199b9f74b0 in zend_persist_class_constant php-src/ext/opcache/zend_persist.c:843:19 #7 0x7f199b9c599c in zend_persist_class_entry php-src/ext/opcache/zend_persist.c:926:4 #8 0x7f199b9400a5 in zend_accel_inheritance_cache_add php-src/ext/opcache/ZendAccelerator.c:2420:23 #9 0x5641f22e8347 in zend_try_early_bind php-src/Zend/zend_inheritance.c:3430:13 #10 0x7f199bb782a4 in zend_accel_do_delayed_early_binding php-src/ext/opcache/zend_accelerator_util_funcs.c:362:11 #11 0x7f199bb76743 in zend_accel_load_script php-src/ext/opcache/zend_accelerator_util_funcs.c:417:3 #12 0x7f199b9078e1 in persistent_compile_file php-src/ext/opcache/ZendAccelerator.c:2229:9 #13 0x5641f17f334c in zend_execute_script php-src/Zend/zend.c:1892:28 #14 0x5641f11c4668 in php_execute_script_ex php-src/main/main.c:2507:13 #15 0x5641f11c5718 in php_execute_script php-src/main/main.c:2547:9 #16 0x5641f2806053 in do_cli php-src/sapi/cli/php_cli.c:966:5 #17 0x5641f2801454 in main php-src/sapi/cli/php_cli.c:1340:18 #18 0x7f19a242814f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #19 0x7f19a2428208 in __libc_start_main csu/../csu/libc-start.c:360:3 #20 0x5641ef2033a4 in _start (php-src/sapi/cli/php+0x1c033a4) (BuildId: 95921ded0c1e297942d1485268c05dddd0a9385e) 0x60d000000000 is located 64 bytes before 136-byte region [0x60d000000040,0x60d0000000c8) freed by thread T0 here: #0 0x5641ef29e429 in __interceptor_realloc (php-src/sapi/cli/php+0x1c9e429) (BuildId: 95921ded0c1e297942d1485268c05dddd0a9385e) #1 0x5641f183f421 in zend_register_functions php-src/Zend/zend_API.c:3001:26 #2 0x5641f1838ee6 in zend_register_module_ex php-src/Zend/zend_API.c:2568:27 #3 0x5641f1843259 in zend_register_internal_module php-src/Zend/zend_API.c:2584:9 #4 0x5641f11b4fe8 in php_register_extensions php-src/main/main.c:2004:8 #5 0x5641f27ff364 in php_register_internal_extensions php-src/main/internal_functions_cli.c:88:9 #6 0x5641f11b6114 in php_module_startup php-src/main/main.c:2204:6 #7 0x5641f2809bc8 in php_cli_startup php-src/sapi/cli/php_cli.c:410:9 #8 0x5641f2800cc7 in main php-src/sapi/cli/php_cli.c:1307:6 #9 0x7f19a242814f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 previously allocated by thread T0 here: #0 0x5641ef29e429 in __interceptor_realloc (php-src/sapi/cli/php+0x1c9e429) (BuildId: 95921ded0c1e297942d1485268c05dddd0a9385e) #1 0x5641f183f421 in zend_register_functions php-src/Zend/zend_API.c:3001:26 #2 0x5641f1838ee6 in zend_register_module_ex php-src/Zend/zend_API.c:2568:27 #3 0x5641f1843259 in zend_register_internal_module php-src/Zend/zend_API.c:2584:9 #4 0x5641f11b4fe8 in php_register_extensions php-src/main/main.c:2004:8 #5 0x5641f27ff364 in php_register_internal_extensions php-src/main/internal_functions_cli.c:88:9 #6 0x5641f11b6114 in php_module_startup php-src/main/main.c:2204:6 #7 0x5641f2809bc8 in php_cli_startup php-src/sapi/cli/php_cli.c:410:9 #8 0x5641f2800cc7 in main php-src/sapi/cli/php_cli.c:1307:6 #9 0x7f19a242814f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 SUMMARY: AddressSanitizer: heap-buffer-overflow php-src/Zend/zend_alloc.c:1433:3 in zend_mm_free_heap Shadow bytes around the buggy address: 0x60cffffffd80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x60cffffffe00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x60cffffffe80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x60cfffffff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x60cfffffff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x60d000000000:[fa]fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x60d000000080: fd fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa 0x60d000000100: fa fa fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x60d000000180: fd fd fd fa fa fa fa fa fa fa fa fa 00 00 00 00 0x60d000000200: 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa fa 0x60d000000280: fa fa fa fa fa fa 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==759376==ABORTING ``` But I expected this output instead: ``` Success ``` Found as part of # ### PHP Version git master ### Operating System Ubuntu 23.10

« previous php.bugs (#246848) next »