[php-src] Issue #15685: improve `proc_open` error reporting on Windows

From: Date: Sun, 01 Sep 2024 00:53:53 +0000
Subject: [php-src] Issue #15685: improve `proc_open` error reporting on Windows
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-247662@lists.php.net to get a copy of this message
Issue: https://github.com/php/php-src/issues/15685 Author: determin1st ### Description i was launching processes recently and got a Warning: "CreateProcess failed with error code 8" that is generated here: https://github.com/php/php-src/blob/acd31dfb9927e494c408a226edd12eca2a73b0e5/ext/standard/proc_open.c#L1320 ```c if (newprocok == FALSE) { //DWORD dw = GetLastError(); close_all_descriptors(descriptors, ndesc); //php_error_docref(NULL, E_WARNING, "CreateProcess failed, error code: %u", dw); php_win32_docref1_from_error( GetLastError(), ZSTR_VAL(command_str) ); goto exit_fail; } ``` ive replaced php_error_docref function with windows specific function which said that was a lack of memory, instead of code 8. so kind of tested it.

« previous php.bugs (#247662) next »