#20371 [Opn->Csd]: Wrong NEWS entry. This change should read 4.2.3 not 4.3.0.

From: Date: Wed, 13 Nov 2002 18:29:31 +0000
Subject: #20371 [Opn->Csd]: Wrong NEWS entry. This change should read 4.2.3 not 4.3.0.
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-24826@lists.php.net to get a copy of this message
 ID:               20371
 Updated by:       sniper@php.net
 Reported By:      alasdair@alivewww.com
-Status:           Open
+Status:           Closed
 Bug Type:         Unknown/Other Function
 Operating System: FreeBSD
 PHP Version:      4.2.3
 New Comment:

This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.


We can't really change 'history' but in 4.3.0, the entry will be in
correct place. :)



Previous Comments:
------------------------------------------------------------------------

[2002-11-13 00:30:53] philip@php.net

Okay, someone put this in the wrong NEWS.

  http://www.php.net/php4news

This is not a doc problem, reclassified so this will make it to php-dev
not phpdoc.  Someone needs to edit NEWS.

------------------------------------------------------------------------

[2002-11-12 22:16:56] alasdair@alivewww.com

Updated Summary to make it more relevant.

------------------------------------------------------------------------

[2002-11-12 22:03:49] alasdair@lumsden.biz

In the source of 4.2.3 that I downloaded, the code has been changed to
include this check in safe mode.

It is not in the 4.2.3 NEWS file in the source I downloaded, or on the
4.2.3 Change Log: http://www.php.net/ChangeLog-4.php

As I say, it has been comitted to the 4.2.3 source as far as I can see,
the code is right here in mail.c:

if (PG(safe_mode) && (ZEND_NUM_ARGS() == 5)) {
      php_error(E_WARNING, "%s(): SAFE MODE Restriction in effect.  The
fifth parameter is disabled in SAFE MODE.",
get_active_function_name(TSRMLS_C));
      RETURN_FALSE;
}

Am I to understand this has been documented as a 4.3.0 change?

------------------------------------------------------------------------

[2002-11-12 19:18:34] philip@php.net

It's not listed in that changelog because that changelog updates
depending on current stable PHP version.  It does not show 4.3.0
entries as the current stable version is 4.2.3

The question is when did this _really_ get committed?  It's in the
4.3.0 NEWS yet is currently documented as a 4.2.3 change.  I am
assuming this is a documentation bug for now.

------------------------------------------------------------------------

[2002-11-11 17:06:35] alasdair@alivewww.com

It is however not mentioned on:

http://www.php.net/ChangeLog-4.php

It is not mentioned on this change log that it is
summarised/incomplete. While it may be mentioned elsewhere, this is
more a complaint about the front page change log than anything else.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/20371

-- 
Edit this bug report at http://bugs.php.net/?id=20371&edit=1



Thread (1 message)

  • sniper@php.net
  • Unknown Message
    • sniper@php.net
« previous php.bugs (#24826) next »