[php-src] Issue #20274: SoapClient::__doRequest undocumented backwards incompatible in PHP 8.5
| From: | brainfoolong | Date: | Fri, 24 Oct 2025 06:24:25 +0000 |
| Subject: | [php-src] Issue #20274: SoapClient::__doRequest undocumented backwards incompatible in PHP 8.5 | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-251109@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/20274
Author: brainfoolong
### Description
I found an undocumented backwards incompatible change that is breaking exsint SoapClient
implementations?!
Here, this break is not listed
https://github.com/php/php-src/blob/php-8.5.0RC3/UPGRADING
Here, this change is documented but not as breaking
https://github.com/php/php-src/blob/ad19b3e570e0760ec55f4357ae69f989345e4d61/NEWS#L341
The signature of SoapClient::__doRequest has changed, so it triggers the following errors in
userland code
```
Declaration of xxxt::__doRequest($request, $location, $action, $version, $oneWay = 0): ?string must
be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int
$version, bool $oneWay = false, ?string $uriParserClass = null): ?string
```
Which i guess is quite common because you almost always have to override this function in
SoapClient.
Do i miss something?
### PHP Version
```plain
PHP 8.5RC3, since PHP 8.5beta1
```
### Operating System
_No response_