[php-src] Issue #23948: Io\Poll: data buffered by the stream layer is not reported, and a stream closed while watched is never reported
| From: | frodeborli | Date: | Sun, 27 Sep 2026 16:30:03 +0000 |
| Subject: | [php-src] Issue #23948: Io\Poll: data buffered by the stream layer is not reported, and a stream closed while watched is never reported | ||
| Groups: | php.bugs | ||
| Request: | Send a blank email to php-bugs+get-252833@lists.php.net to get a copy of this message | ||
Issue: https://github.com/php/php-src/issues/23948
Author: frodeborli
### Description
@bukka — I've been writing a poller for phasync (a coroutine library) on top of
Io\Poll, next to our stream_select() one, and ran our test suite against
master. Two behaviours make a correct event loop hard to build on it, and both differ from
stream_select():
**1. Data already in the stream's read buffer isn't reported.** After a read that buffered
more than it returned (typical with fgets()), the socket is empty but the stream has
unread data. stream_select() counts that stream as readable; Io\Poll only
looks at the fd, so a loop that waits for readability before its next read never wakes.
```php
use Io\Poll\{Context, Event};
[$a, $b] = stream_socket_pair(STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP);
fwrite($b, "first\nsecond\n");
fgets($a); // "first\n"; "second\n" is now in $a's read buffer, the socket
is empty
$r = [$a]; $w = $e = null;
var_dump(stream_select($r, $w, $e, 0)); // int(1)
$poll = new Context();
$poll->add(new StreamPollHandle($a), [Event::Read]);
var_dump(count($poll->wait(Time\Duration::fromMilliseconds(100)))); // int(0)
```
We work around it by checking stream_get_meta_data($s)['unread_bytes'] before
every wait, but every user of the API will hit this. Perhaps wait() could return the
watchers of streams with buffered read data at once (as stream_select() does through
stream_array_emulate_read_fd_set()), with Event::Read triggered.
**2. A stream closed while watched is never reported.** Since #23822, fclose() retires
the watcher (which fixed the use-after-free), but wait() never tells the loop. A
coroutine or callback waiting on that stream waits forever, unless the loop scans every
watcher's isActive() periodically and caps its waits to do so:
```php
use Io\Poll\{Context, Event};
[$a, $b] = stream_socket_pair(STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP);
$poll = new Context();
$watcher = $poll->add(new StreamPollHandle($a), [Event::Read]);
fclose($a); // elsewhere in the program, while something waits on $a
var_dump($watcher->isActive()); // bool(false)
var_dump(count($poll->wait(Time\Duration::fromMilliseconds(100)))); // int(0): nobody is told
```
With stream_select() the next call throws on the closed stream (TypeError,
or ValueError when it was the only one), so the loop can find and wake its waiter.
Perhaps the next wait() could return a watcher retired by a close once, inactive, (e.g.
with Event::HangUp triggered), so the loop wakes its waiter without scanning.
Let me know if you'd like me to write a PR for either.
### PHP Version
```
PHP 8.7.0-dev (master)
```
### Operating System
Linux (epoll backend)