#21760 [Com]: socket_read PHP_NORMAL_READ problem

ID: 21760 Comment by: chuck at fuck dot org Reported By: sunday at csh dot rit dot edu Status: Feedback Bug Type: Sockets related Operating System: FreeBSD 4.7 PHP Version: 4.3.0 New Comment: I've upgraded to tonights CVS and still have the same problem with socket_read. The fix posted did work for 4.3.0 but i'm hesitant to use it again for obvious reasons. Previous Comments: ------------------------------------------------------------------------ [2003-02-27 10:16:20] iliaa@php.net Please try using this CVS snapshot: http://snaps.php.net/php4-STABLE-latest.tar.gz For Windows: http://snaps.php.net/win32/php4-win32-STABLE-latest.zip Works fine here with latest stable CSV. The path you prose is bogus because it overwrites the 1st byte in t with a 0. ------------------------------------------------------------------------ [2003-02-05 21:13:53] chip at cyan dot com ah. found my windows 2000 socket_read bug: http://bugs.php.net/bug.php?id=21197 ------------------------------------------------------------------------ [2003-02-05 21:08:07] chip at cyan dot com I can repeat this bug. here is an example script that i used: http://force-elite.com/~chip/test/socket_phpreadnormal.phps it is a modification of the basic HTTP client given as an example in the PHP.net documentation. When PHP_NORMAL_READ is used, and certen buffer sizes, it will resuilt in socket_read returning bogus data, commonly all newlines(\n). On both a FreeBSD-4.7-stable(built Fri Nov 29), and FreeBSD-5.0-RC(built Wed Jan 8), both using PHP-4.3.0-cli, with a buffer size of 2048 it would work, with a buffer size of 100, socket_read() would return a stream of \n. On Linux 2.4.18-18.7.x(Redhat Box) using PHP-4.3.0-cli, it would always work, regardless of the buffer size. On Linux 2.4.19-crypto-r7(Gentoo Box) using PHP-4.3.0-cli, it would work with 2048 buffer size, but with 100 it would bail with: Notice: Undefined offset: 0 in /path/socket_phpreadnormal.php on line 51 Warning: socket_read() expects parameter 1 to be resource, null given in /path/socket_phpreadnormal.php on line 51 (I don't have direct access to this box, I didn't want to heavly debug it, it is possibly an error in my script.) On Windows 2000, using PHP-4.3.0-cli, it would always return 0(EOF) from socket_read(). It Bailed with: Warning: socket_read() unable to read from socket [0]: The operation completed successfully. (perhaps a seperate bug :-) ) ------------------------------------------------------------------------ [2003-02-05 09:53:04] uce at ftc dot gov I believe this is caused by a comparison to an uninitialized buffer in php_read (buffer emalloc'd in socket_read). Patch: --- php5/ext/sockets/sockets.c 2003-01-18 19:28:06.000000000 +0000 +++ php5-atropine/ext/sockets/sockets.c 2003-02-05 15:43:00.000000000 +0000 @@ -288,6 +288,7 @@ set_errno(0); + *t = 0; while (*t != '\n' && *t != '\r' && n < maxlen) { if (m > 0) { t++; ------------------------------------------------------------------------ [2003-01-19 23:18:44] sunday at csh dot rit dot edu $string = socket_read( $socket, 100, PHP_NORMAL_READ ); will return a "\n" after several reads, and continue to return "\n" in an infinite loop rather than the rest of the buffer. The server it's reading from sends a large multi-line (lines terminated with "\n") packet (~7500 bytes) in one write() call. After reading through about half of it with the line above, socket_read will start returning bad data about 10% - 20% of the time. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=21760&edit=1