#22882 [Opn->Bgs]: shmop_read should return string length, not shm segment size
| From: | wez@php.net | Date: | Tue, 25 Mar 2003 20:50:47 +0000 |
| Subject: | #22882 [Opn->Bgs]: shmop_read should return string length, not shm segment size | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-36410@lists.php.net to get a copy of this message | ||
ID: 22882
Updated by: wez@php.net
Reported By: discussion at vodopivec dot com
-Status: Open
+Status: Bogus
Bug Type: Strings related
Operating System: Linux
PHP Version: 4.3.1
New Comment:
This would break binary data stored in the shm segment; we will not
apply this patch.
Previous Comments:
------------------------------------------------------------------------
[2003-03-25 14:42:08] discussion at vodopivec dot com
My opinion is that shmop_read function has wrong behaviour, returning
'count' parameter as the length of the string, instead of real length
of the string, up to the terminating zero.
This should be easy to fix, in fact I already did, but
someone should apply this patch - in shmop_read,
instead of
RETURN_STRINGL(return_string, bytes, 0);
you can use
RETURN_STRINGL(return_string, strlen(return_string), 0);
Below is the php code that demonstrates this problem.
Thanks,
Mario.
<?php
$buffer = "12345";
// Create 100 byte shared memory block with system id if 0xff3
$shm_id = shmop_open(0xff3, "c", 0644, 100);
if(!$shm_id) {
echo "Couldn't create shared memory segment\n";
}
// Get shared memory block's size
$shm_size = shmop_size($shm_id);
echo "SHM Block Size: ".$shm_size. " has been created.\n";
// Lets write a test string into shared memory
$shm_bytes_written = shmop_write($shm_id, $buffer, 0);
if($shm_bytes_written != strlen($buffer)) {
echo "Couldn't write the entire length of data\n";
}
// Now lets read the string back
$my_string = shmop_read($shm_id, 0, $shm_size);
if(!$my_string) {
echo "Couldn't read from shared memory block\n";
}
echo "The data inside shared memory was: ".$my_string."<br>\n";
if ($my_string != $buffer)
{
print "This is where it doesn't make sense"."<br>\n";
print "buffer len = ".strlen($buffer)."<br>\n";
print "my string len = ".strlen($my_string)."<br>\n";
}
//Now lets delete the block and close the shared memory segment
if(!shmop_delete($shm_id)) {
echo "Couldn't mark shared memory block for deletion.";
}
else
echo "Deleted shm block";
shmop_close($shm_id);
?>
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=22882&edit=1