#24009 [Asn->Csd]: FCGX_Finish_r() isn't called if no SCRIPT_FILENAME is provided

ID: 24009 Updated by: shane@php.net Reported By: jan at kneschke dot de -Status: Assigned +Status: Closed Bug Type: CGI related Operating System: Linux PHP Version: 4CVS-2003-06-04 (stable) Assigned To: shane New Comment: This bug has been fixed in CVS. In case this was a PHP problem, snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites in short time. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2003-06-06 07:20:56] sniper@php.net Shane, you should know this? :) ------------------------------------------------------------------------ [2003-06-04 02:30:10] jan at kneschke dot de I'm using a php with the fastcgi-SAPI for my own webserver lighttpd. While testing various cases I've found a bug in the FastCGI-SAPI in PHP: If no usefull script-filename is sent to the PHP it would send a default error-page with "No input file specified." and status 404. After sending this messsage the module is shutdown without finishing the FastCGI request. This results in a missing FCGI_REQUEST_END packet and is against the FastCGI spec. I don't know if the FCGX_Finished_r() should be called before or after module_shutdown(). Before actually works fine. Index: cgi_main.c =================================================================== RCS file: /repository/php4/sapi/cgi/cgi_main.c,v retrieving revision 1.190.2.37 diff -u -r1.190.2.37 cgi_main.c --- cgi_main.c 31 May 2003 17:02:01 -0000 1.190.2.37 +++ cgi_main.c 4 Jun 2003 07:19:12 -0000 @@ -1487,6 +1487,9 @@ SG(sapi_headers).http_response_code = 404; PUTS("No input file specified.\n"); php_request_shutdown((void *) 0); +#ifdef PHP_FASTCGI + if (fastcgi) FCGX_Finish_r(&request); +#endif php_module_shutdown(TSRMLS_C); return FAILURE; } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=24009&edit=1