#25817 [NEW]: Procedures returning recordset&variables spoiled

From: fjortiz at comunet dot es Operating system: Windows PHP version: 4.3.3 PHP Bug Type: MSSQL related Bug description: Procedures returning recordset&variables spoiled Description: ------------ I helped create the mssql_execute function, and I see a bug has been introduced since 4.1.1 (last time I saw the code) If you craft a stored procedure returning BOTH a recordset and output variables, you'll only get the recordset, not the output variables. This worked fine in 4.1.1 Here is the problem: php_mssql.c, line 2110 if ((num_fields = dbnumcols(mssql_ptr->link)) > 0) { // then get recordset... } else { // get output variables _mssql_get_sp_result(mssql_ptr, statement TSRMLS_CC); } this is wrong. You can get both of them. This is it: if ((num_fields = dbnumcols(mssql_ptr->link)) > 0) { // then get recordset... } // and ALWAYS get the output variables _mssql_get_sp_result(mssql_ptr, statement TSRMLS_CC); I recompiled 4.3.3 php_mssql.dll with this and it works as expected (and as it was back in 4.1.1) BTW it's in 4.3.4rc1 too. -- Edit bug report at http://bugs.php.net/?id=25817&edit=1 -- Try a CVS snapshot (php4): http://bugs.php.net/fix.php?id=25817&r=trysnapshot4 Try a CVS snapshot (php5): http://bugs.php.net/fix.php?id=25817&r=trysnapshot5 Fixed in CVS: http://bugs.php.net/fix.php?id=25817&r=fixedcvs Fixed in release: http://bugs.php.net/fix.php?id=25817&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=25817&r=needtrace Try newer version: http://bugs.php.net/fix.php?id=25817&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=25817&r=support Expected behavior: http://bugs.php.net/fix.php?id=25817&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=25817&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=25817&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=25817&r=globals PHP 3 support discontinued: http://bugs.php.net/fix.php?id=25817&r=php3 Daylight Savings: http://bugs.php.net/fix.php?id=25817&r=dst IIS Stability: http://bugs.php.net/fix.php?id=25817&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=25817&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=25817&r=float