#19317 [Com]: cosmetic problem on line 308 in var_unserializer.c

ID: 19317 Comment by: jessicah at juniper dot net Reported By: phpbugs20020909 at pech dot cz Status: No Feedback Bug Type: Compile Failure Operating System: RedHat Linux 7.3 PHP Version: 4.2.3, 4.3.0-dev New Comment: I got a warning about the comparison with GCC 3.3.2 compiler: php/ext/standard/var_unserializer.c:308:warning: comparison is always false due to limited range of data type '\277' is treated as a signed char by default, thus the value is negative. The warning will go away if we change the comparison to (yych <= (unsigned char)'\277'). Previous Comments: ------------------------------------------------------------------------ [2002-11-03 01:00:02] php-bugs at lists dot php dot net No feedback was provided for this bug for over 2 weeks, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open". ------------------------------------------------------------------------ [2002-10-15 23:42:05] sniper@php.net Please add the error here which you got with latest CVS snapshot and GCC 3.2 when the compile failed. ------------------------------------------------------------------------ [2002-10-15 15:21:05] iliaa@php.net I've just compiled latest CVS using gcc 3.2. It compiled just fine, gave me the same warnings as gcc 2.95.3 gave. If it fails to compile the problem is likely to be else where. The configure line used was: ./configure --disable-all --enable-debug The warnings are certainly something to be fixed, but this is hardly a 'critical' bug. ------------------------------------------------------------------------ [2002-10-12 09:59:36] esben at haabendal dot dk Furthermore, this breaks build with gcc-3.2, so I don't think it is so smart to keep ignoring this. ------------------------------------------------------------------------ [2002-09-09 10:14:08] phpbugs20020909 at pech dot cz There is a comparison (yych <= '\277') on line 308 in file /ext/standard/var_unserializer.c, which is never true (appeared first in "1.6.2.1 by stas"). I suppose that "goto yy15;" is correct, but the comparison is not OK. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=19317&edit=1