#26527 [Opn->Bgs]: Either GC code is wrong or GC documentation is wrong

ID: 26527 Updated by: sniper@php.net Reported By: jneil at myersinternet dot com -Status: Open +Status: Bogus Bug Type: Session related Operating System: Linux PHP Version: 4.3.3 New Comment: From CVS log for mod_files.c: revision 1.76 date: 2002/08/17 20:32:26; author: zeev; state: Exp; lines: +2 -2 Use mtime instead of atime, as we always update the session file anyway. Previous Comments: ------------------------------------------------------------------------ [2003-12-04 15:33:10] jneil at myersinternet dot com Description: ------------ Both the code documentation in mod_files.c (on line 207) and the PHP manual indicate that the garbage cleanup should take place based on a given session file's last access time. However, the element from "struct stat" being used in mod_files.c on line 209 is sbuf.st_mtime (the last modification time) instead of sbuf.st_atime. Either the code is incorrect or the documentation is incorrect. If we can get this synced up properly, then those of us trying to debug session timeout issues will have a much easier time deciding which parameters are governing session timeouts. The coding change may have been to fix problems on a particular platform but the result has been to make the documentation misleading. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26527&edit=1