#26625 [Fbk->Opn]: pg_convert sets NULL incorrectly for character data types

ID: 26625 User updated by: gregkiyomi at digitaljunkies dot ca Reported By: gregkiyomi at digitaljunkies dot ca -Status: Feedback +Status: Open Bug Type: PostgreSQL related Operating System: linux PHP Version: 5.0.0b2 (beta2) New Comment: http://snaps.php.net/php5-latest.tar.gz has the same problem, as does php 4.3. I posted the fix in my original post. In the switch statement in pgsql.c for text types (PG_TEXT,PG_CHAR,PG_VARCHAR) if the string length is 0 and the PGSQL_CONV_FORCE_NULL option is set then the value is set to NULL and then is run through the php_pgsql_add_quotes() function. This results with the value entered as 'NULL' when it should be NULL. The solution, as in my original post is to put a "break;" statement after the value is set to NULL so it doesn't get passed through the add quotes function. This was detailed in the diff I put in the original post. I have added this change and recompiled myself so the bug report was merely for the benefit of the developers and anyone else who's having this problem. Hope this helps!:) Previous Comments: ------------------------------------------------------------------------ [2003-12-15 09:23:22] sniper@php.net Please try using this CVS snapshot: http://snaps.php.net/php5-latest.tar.gz For Windows: http://snaps.php.net/win32/php5-win32-latest.zip ------------------------------------------------------------------------ [2003-12-15 03:32:38] gregkiyomi at digitaljunkies dot ca Description: ------------ When using pg_convert() with PGSQL_CONV_FORCE_NULL option set the resulting value for character data types (text,char,varchar) is set as 'NULL' instead of NULL. This therefore inserts the string 'NULL' into the database instead of the desired NULL value. This also obviously doesn't fail a NOT NULL check as it should. The culprit is ext/pgsql/pgsql.c *** pgsql.c~ Mon Dec 15 00:17:01 2003 --- pgsql.c Mon Dec 15 01:28:56 2003 *************** *** 3785,3790 **** --- 3785,3791 ---- if (Z_STRLEN_PP(val) == 0) { if (opt & PGSQL_CONV_FORCE_NULL) { ZVAL_STRING(new_val, "NULL", 1); + break; } else { ZVAL_STRING(new_val, empty_string, 1); This prevents the NULL value from being passed through php_pgsql_add_quotes(). This is also present in php 4.3.3. Reproduce code: --------------- $con_str = "host=localhost dbname=database user=user password=pass"; $con = pg_connect($con_str); $data = array("varchar_field1"=>"test", "varchar_field2"=>NULL, "varchar_field3"=>""); $array = pg_convert($con,"test_table",$data,4); echo("<pre>"); print_r($array); echo("</pre>"); Expected result: ---------------- Array ( [varchar_field1] => 'test' [varchar_field2] => NULL [varchar_field3] => NULL ) Actual result: -------------- Array ( [varchar_field1] => 'test' [varchar_field2] => NULL [varchar_field3] => 'NULL' ) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26625&edit=1