#26703 [Bgs->Opn]: highlight_string and similar highlights improper characters as a keyword

From:	vrana@php.net	Date:	Thu, 25 Dec 2003 09:55:41 +0000
Subject:	#26703 [Bgs->Opn]: highlight_string and similar highlights improper characters as a keyword
References:	1	Groups:	php.bugs
Request:	Send a blank email to php-bugs+get-52484@lists.php.net to get a copy of this message

ID: 26703 User updated by: vrana@php.net Reported By: vrana@php.net -Status: Bogus +Status: Open Bug Type: Scripting Engine problem Operating System: Any PHP Version: 4.3.4 New Comment: There are two issues with the highlighting. I described them quite precisely. It can not be expected behavior as it behave strange (1) and inconsistent (2). The fix is easy and I already sent a patch for it. Why don't you accept the patch and marking this bug bogus again and again? Previous Comments: ------------------------------------------------------------------------ [2003-12-25 04:47:42] derick@php.net It's all the same issue, get over it. ------------------------------------------------------------------------ [2003-12-25 04:39:48] vrana@php.net This is different. In #26629, I complain about not highlighting some characters in constant strings. As you told me that it will be hard to implement, I sent this bug report complaining about highlighting those characters in non-constant strings (so it is opposite). Besides there's another issue with this (marked as 1.). Can you please read whole bug report and take a look on sent patch? There are two reasons to accept it and no reason to reject it. ------------------------------------------------------------------------ [2003-12-23 04:12:06] derick@php.net Please do not submit the same bug more than once. An existing bug report already describes this very problem. Even if you feel that your issue is somewhat different, the resolution is likely to be the same. Thank you for your interest in PHP. You already reported a bug about this before. ------------------------------------------------------------------------ [2003-12-23 03:36:16] vrana@php.net Description: ------------ There are two issues with highlight_string, highlight_file and `php -s`: 1. Some characters (like []{}) are highlighted in non-constant strings (i.e. double quote strings with variables) as a keyword even on places where they don't have any special purpose. 2. Some characters ([]{} and backslash sequences) are highlighted in non-constant strings and aren't highlighted in constant strings. It should be consistent. Suggested solution: Don't highlight anything as a keyword both in constant and non-constant strings. I've already sent a patch for this to internals@lists.php.net. Reproduce code: --------------- <?php highlight_string('<?php "foo[] $a \n"; ?>'); ?> Expected result: ---------------- <code> <?php "foo[] $a \n"; ?> </code> Actual result: -------------- <code> <?php "foo[] $a \n"; ?> </code> ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26703&edit=1