#26848 [WFx]: Make highlight functions XHTML 1.0 Strict compliant

ID: 26848 User updated by: phpman at fosketts dot co dot uk Reported By: phpman at fosketts dot co dot uk Status: Wont fix Bug Type: Feature/Change Request Operating System: Win XP PHP Version: 4.3.4 New Comment: Surely standards compliance matters now. Any developer wishing to use these functions within a XHTML 1.0 Strict document will have to perform extra steps, even though a 'fix' could very easily be applied I guess I'll have to keep doing this: $str = preg_replace ( '#\<font color\=\"(.+?)\"\>#is', '<span style="color: $1">', $str ); $str = str_replace ( '</font>', '</span>', $str ); Sean :) Previous Comments: ------------------------------------------------------------------------ [2004-01-10 10:21:01] moriyoshi@php.net We'll do so when standard compliance really matters. (IIRC, the current output is valid XHTML 1.0 transitional.) ------------------------------------------------------------------------ [2004-01-08 14:49:15] phpman at fosketts dot co dot uk Description: ------------ Will the highlight functions (highlight_string() and highlight_file()) be modified to produce valid XHTML 1.0 Strict output? This has already been done in other functions, e.g. nl2br(). A simple solution would be to edit zend_highlight.c as follows: 1) Replace <font color=\"%s\"> with <span style=\"color: %s\"> on lines 106 and 155 2) Replace </font> with </span> on lines 151, 191 and 193 Thanks Sean :) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26848&edit=1