#26927 [Opn->Csd]: preg_quote and/or preg_match disrespect embedded null chars in strings

From: Date: Fri, 16 Jan 2004 02:29:48 +0000
Subject: #26927 [Opn->Csd]: preg_quote and/or preg_match disrespect embedded null chars in strings
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-53405@lists.php.net to get a copy of this message 
 ID:               26927
 Updated by:       iliaa@php.net
 Reported By:      ikindred at cox dot net
-Status:           Open
+Status:           Closed
 Bug Type:         PCRE related
 Operating System: FreeBSD 4.9
 PHP Version:      4.3.4
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2004-01-15 19:45:35] ikindred at cox dot net

Description:
------------
At first glance, either or both of the following are bugs:

1. preg_quote does not properly escape the null character (\000).

2. preg_match chokes on patterns containing unescaped null characters.

I personally want to think that preg_match should be able to handle
patterns containing null characters.  However, according to Bug #16590,
preg_match's behavior is a feature and not a bug - oh well.  (I also
recognize that there may be legitimate performance reasons for
disallowing null chars in patterns.)

I therefore claim that preg_quote is buggy should be fixed.  Please
note that:

(a) preg_quote ("a\000b") returns "a\000b", so it is not like
preg_quote is treating the \000 as an end-of-string character (which
would result in "a" being returned).  preg_quote is just passing the
\000 through without escaping it.

(b) As far as I can tell, there is no "preg_quote" function in the PCRE
library (specifically, there is no function with "quote" as part of its
name).  So, as far as I can tell, PHP cannot blame the PCRE for
preg_quote's buggy behavior.

Many thanks!

Reproduce code:
---------------
<?php

$pattern = "/". preg_quote ("a\000b"). "/";
print "preg_match: ". preg_match ($pattern, "a\000b"). "\n";

?>


Expected result:
----------------
preg_match: 1


Actual result:
--------------
Warning: No ending delimiter '/' found in /<path>/test.php on line 4
preg_match: 



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=26927&edit=1

Thread (2 messages)

« previous php.bugs (#53405) next »