#26937 [Opn->Csd]: Warning in xml.c

ID: 26937 Updated by: sniper@php.net Reported By: spam at pasher dot org -Status: Open +Status: Closed Bug Type: Compile Warning Operating System: Debian Linux 2.4.20 PHP Version: 4.3.5RC1 New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2004-01-16 12:22:17] spam at pasher dot org Description: ------------ When compiling PHP (even as of 4.3.5RC1), it outputs the following warning: /php-4.3.5RC1/ext/xml/xml.c: In function `xml_utf8_encode': /php-4.3.5RC1/ext/xml/xml.c:489: warning: comparison is always true due to limited range of data type /php-4.3.5RC1/ext/xml/xml.c:493: warning: comparison is always true due to limited range of data type It looks like the variable in question (c) is declared as unsigned short. It is later being compared to 0x10000 and 0x200000, which is two large for a short. I would assume an unsigned int would be enough. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=26937&edit=1