#27093 [Asn->Csd]: Incorrect casts in oci8.c prevent compiling with Oracle 10g

From: Date: Tue, 03 Feb 2004 19:51:14 +0000
Subject: #27093 [Asn->Csd]: Incorrect casts in oci8.c prevent compiling with Oracle 10g
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-54350@lists.php.net to get a copy of this message
 ID:               27093
 Updated by:       sniper@php.net
 Reported By:      cjbj at hotmail dot com
-Status:           Assigned
+Status:           Closed
 Bug Type:         OCI8 related
 Operating System: RH Linux 3
 PHP Version:      4CVS-2004-01-30 (stable)
 Assigned To:      tony2001
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2004-02-03 08:31:40] sniper@php.net

Assigned to the maintainer of ext/oci8


------------------------------------------------------------------------

[2004-02-02 00:39:27] cjbj at hotmail dot com

To compile with Oracle 10g also see http://bugs.php.net/27117

------------------------------------------------------------------------

[2004-02-01 19:22:43] cjbj at hotmail dot com

Diff -cw gives:

*** oci8.c.orig	2004-01-27 01:08:29.000000000 +1100
--- oci8.c	2004-02-02 11:24:46.000000000 +1100
***************
*** 4833,4839 ****
  			CALL_OCI_RETURN(connection->error, OCICollAppend(
  				  connection->session->pEnv, 
  				  connection->pError, 
! 				  (dword *)0, 
  				  &null_ind, 
  				  coll->coll));
  			if (connection->error) {
--- 4833,4839 ----
              CALL_OCI_RETURN(connection->error, OCICollAppend(
                    connection->session->pEnv,
                    connection->pError,
!                   (dvoid *)0,
                    &null_ind,
                    coll->coll));
              if (connection->error) {
***************
*** 5139,5145 ****
  				  connection->session->pEnv, 
  				  connection->pError, 
  				  ndx, 
! 				  (dword *)0, 
  				  &null_ind, 
  				  coll->coll));
  			if (connection->error) {
--- 5139,5145 ----
                    connection->session->pEnv,
                    connection->pError,
                    ndx,
!                   (dvoid *)0,
                    &null_ind,
                    coll->coll));
              if (connection->error) {
***************
*** 5172,5178 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)&dt, 
  							&new_ind, 
  							coll->coll));
  
--- 5172,5178 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)&dt,
                              &new_ind,
                              coll->coll));
  
***************
*** 5200,5206 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)ocistr, 
  							&new_ind, 
  							coll->coll));
  
--- 5200,5206 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)ocistr,
                              &new_ind,
                              coll->coll));
  
***************
*** 5239,5245 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)&num, 
  							&new_ind, 
  							coll->coll));
  
--- 5239,5245 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)&num,
                              &new_ind,
                              coll->coll));

------------------------------------------------------------------------

[2004-01-30 02:04:49] cjbj at hotmail dot com

Description:
------------
The casts to "(dword *)" in OCICollAppend() and OCICollAssignElem()
calls in oci8.c should be changed to "(dvoid *)" to match the
prototypes.  

Without this correction the file will fail to compile in Oracle 10g:
the very obsolete dword no longer appears to be defined in oratypes.h.



Actual result:
--------------
Without this fix, compiling php4-STABLE-200401300430 with --enable-oci8
gives:

  /home/cjbj/php/ext/oci8/oci8.c:4833: `dword' undeclared (first use in
this function)


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=27093&edit=1


Thread (5 messages)

« previous php.bugs (#54350) next »