#27268 [Opn]: Bad references accentuated by clone

From: Date: Mon, 16 Feb 2004 04:47:13 +0000
Subject: #27268 [Opn]: Bad references accentuated by clone
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-54980@lists.php.net to get a copy of this message
 ID:               27268
 User updated by:  lingwitt at bellsouth dot net
 Reported By:      lingwitt at bellsouth dot net
 Status:           Open
 Bug Type:         Class/Object related
 Operating System: Mac OS X
 PHP Version:      5.0.0b4 (beta4)
 New Comment:

In fact, the reference doesn't need to be made in a 
method:

class A
{
    var $a = array();
    
    public function &getA()
    {
        return $this->a;
    }
}

$A = new A;
$A->a = array(1);
$array = $A->getA();
$clone = clone $A;
$clone->a = array();

print_r($A);


Previous Comments:
------------------------------------------------------------------------

[2004-02-15 23:43:53] lingwitt at bellsouth dot net

No it's not.

------------------------------------------------------------------------

[2004-02-15 23:20:08] sniper@php.net

Yes, expected behaviour.


------------------------------------------------------------------------

[2004-02-15 21:06:03] lingwitt at bellsouth dot net

Description:
------------
When an object's method calls upon another one of its 
methods such that the second method returns a reference 
that is stored in the the first method as a local 
variable, then the reference persists in some way so as 
to make cloning problematic.

As a result, a modification to the referenced variable 
in the clone cuases a modification to the same variable 
in original.

Reproduce code:
---------------
class A
{
    var $a = array();
    
    public function makeAReference()
    {
        $array = $this->getA();
    }
    
    public function &getA()
    {
        return $this->a;
    }
}

$A = new A;
$A->a = array(1);
$A->makeAReference();
$clone = clone $A;
$clone->a = array();

print_r($A);

Expected result:
----------------
This is gotten when $A->makeAReference() is removed.

A Object
(
    [a] => Array
        (
            [0] => 1
        )

)

Actual result:
--------------
Obviously the modification made it back to the original.

A Object
(
    [a] => Array
        (
        )

)


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=27268&edit=1


Thread (10 messages)

« previous php.bugs (#54980) next »