#27337 [Opn->Ver]: [PATCH] Failure to call sapi_shutdown() leaves memory leak

From: Date: Sun, 22 Feb 2004 23:29:42 +0000
Subject: #27337 [Opn->Ver]: [PATCH] Failure to call sapi_shutdown() leaves memory leak
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-55329@lists.php.net to get a copy of this message
ID: 27337 Updated by: sniper@php.net -Summary: Failure to call sapi_shutdown() leaves memory leak Reported By: msisolak at yahoo dot com -Status: Open +Status: Verified Bug Type: IIS related Operating System: Windows 2000 -PHP Version: 5CVS-2004-02-21 (dev) +PHP Version: 4CVS, 5CVS (2004-02-23) Previous Comments: ------------------------------------------------------------------------ [2004-02-21 17:06:37] msisolak at yahoo dot com The PHP_4_3 branch ISAPI also does not call sapi_shutdown(). I see no indication of a reason to not call this function to balance the call to sapi_startup(), so I would think it should be added to both the PHP_4_3 branch and HEAD. ------------------------------------------------------------------------ [2004-02-21 02:52:13] sniper@php.net Does this apply to PHP_4_3 branch too? ------------------------------------------------------------------------ [2004-02-21 00:28:39] msisolak at yahoo dot com Description: ------------ The ISAPI doesn't call sapi_shutdown() so the known_post_content_types hash tables doesn't get freed. Patch: --- php5isapi.c.orig Tue Feb 17 17:07:14 2004 +++ php5isapi.c Tue Feb 17 17:03:54 2004 @@ -935,6 +935,7 @@ if (isapi_sapi_module.shutdown) { isapi_sapi_module.shutdown(&sapi_module); } + sapi_shutdown(); tsrm_shutdown(); break; } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=27337&edit=1

« previous php.bugs (#55329) next »