#27681 [Asn->Csd]: soap extension fails without HAVE_TM_GMTOFF

ID: 27681 Updated by: dmitry@php.net Reported By: jwm at horde dot net -Status: Assigned +Status: Closed Bug Type: SOAP related Operating System: Solaris 8 PHP Version: 5.0.0RC1 Assigned To: dmitry New Comment: Fixed in 5.0.0RC2-dev CVS. Please, verify me on Solaris. Previous Comments: ------------------------------------------------------------------------ [2004-04-07 11:16:01] sniper@php.net Assigned to the maintainer. ------------------------------------------------------------------------ [2004-03-24 16:43:05] jwm at horde dot net Description: ------------ The soap extension fails to build (undefined variables) on Solaris 8 because the !HAVE_TM_GMTOFF case requires tzone, which is not defined. This (perhaps naive) patch fixes the build, but I haven't tested it: --- ext/soap/php_encoding.c~ 2004-03-20 17:10: 22.646093000 -0500 +++ ext/soap/php_encoding.c 2004-03-20 17:10: 22.656085000 -0500 @@ -2119,6 +2119,7 @@ size_t buf_len=64, real_len; char *buf; char tzbuf[6]; + long tzone; xmlNodePtr xmlParam; @@ -2130,7 +2131,13 @@ timestamp = Z_LVAL_P(data); ta = php_localtime_r(&timestamp, &tmbuf); /*ta = php_gmtime_r(&timestamp, &tmbuf); */ - +#if !HAVE_TM_GMTOFF +#ifdef __CYGWIN__ + tzone = _timezone; +#else + tzone = timezone; +#endif +#endif buf = (char *) emalloc(buf_len); while ((real_len = strftime(buf, buf_len, format, ta)) == buf_len || real_len == 0) { buf_len *= 2; ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=27681&edit=1