#28346 [Opn->Bgs]: Parameters from PEAR http_proxy not unencoded

ID: 28346 Updated by: eru@php.net Reported By: i at camerongreen dot org -Status: Open +Status: Bogus Bug Type: Unknown/Other Function Operating System: Fedora Core 1 PHP Version: Irrelevant New Comment: Sorry, but your problem does not imply a bug in PHP itself. For a list of more appropriate places to ask for help using PHP, please visit http://www.php.net/support.php as this bug system is not the appropriate forum for asking support questions. Thank you for your interest in PHP. Hi, please report your bug in the PEAR bug database, which you can usually reach under http://pear.php.net/package/Pear (for the PEAR package) or http://pear.php.net/bugs/ for general instructions. Thanks for your interest in PHP! Previous Comments: ------------------------------------------------------------------------ [2004-05-10 10:15:34] i at camerongreen dot org fixing email address : ) ------------------------------------------------------------------------ [2004-05-10 10:15:17] cgreen at its dot uq dot edu dot au fixing email address : ) ------------------------------------------------------------------------ [2004-05-10 10:13:46] i at camerongreen dot org Description: ------------ The Remote.php class in the PEAR installer does not urldecode parameters after it parses the URL. This means that if a password contains the wrong characters, it will not work. For instance http://username:p@ssword@proxy.my.url.com will cause an error because the @ symbol in p@ssword will confuse it. You therefore need to urlencode the @ to %40, and after parse_url has seperated it in the code, urldecode it. Cheerio, Cameron Reproduce code: --------------- Easy fix... % diff /usr/local/php-5-0-0rc1/lib/php/PEAR/Remote.php /usr/local/php-5-0-0rc1/lib/php/PEAR/Remote.php.old 138,139c138,139 < $proxy_user = urldecode(@$proxy['user']); < $proxy_pass = urldecode(@$proxy['pass']); --- > $proxy_user = @$proxy['user']; > $proxy_pass = @$proxy['pass']; ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=28346&edit=1