#28949 [Opn->Fbk]: imagetruecolortopalette - colors in palette are missing and filled with white

ID: 28949 Updated by: derick@php.net Reported By: vkary at web dot de -Status: Open +Status: Feedback Bug Type: GD related Operating System: WinXP & Linux PHP Version: 4.3.7 New Comment: Please try using this CVS snapshot: http://snaps.php.net/php5-latest.tar.gz For Windows: http://snaps.php.net/win32/php5-win32-latest.zip Previous Comments: ------------------------------------------------------------------------ [2004-07-23 13:24:52] vkary at web dot de BOUTELL.COM: ------------- "07/21/04: gd 2.0.28 has been released. gd 2.0.28 restores support for reading and writing GIF images. There is also a fix for a possible problem in gdImageTrueColorToPalette." ------------------------------------------------------------------------ [2004-07-23 01:11:12] iliaa@php.net Please try using this CVS snapshot: http://snaps.php.net/php4-STABLE-latest.tar.gz For Windows: http://snaps.php.net/win32/php4-win32-STABLE-latest.zip ------------------------------------------------------------------------ [2004-07-14 12:55:50] service at textilenetwork dot de This bug still exists in release of PHP 5! ------------------------------------------------------------------------ [2004-07-03 12:16:54] vkary at web dot de ...and another difference: A few lines above, the variable "count" is initialized with "0" ------------------------------------------------------------------------ [2004-07-03 11:58:53] vkary at web dot de I have found a difference between the PHP 4.3.2 and PHP 4.3.7 in the file "gd_topal.c" gd_topal.c, PHP 4.3.2, lines 733-742 ------------------------------------- #ifdef ORIGINAL_LIB_JPEG cinfo->colormap[0][icolor] = (JSAMPLE) ((c0total + (total >> 1)) / total); cinfo->colormap[1][icolor] = (JSAMPLE) ((c1total + (total >> 1)) / total); cinfo->colormap[2][icolor] = (JSAMPLE) ((c2total + (total >> 1)) / total); #else im->red[icolor] = (int) ((c0total + (total >> 1)) / total); im->green[icolor] = (int) ((c1total + (total >> 1)) / total); im->blue[icolor] = (int) ((c2total + (total >> 1)) / total); #endif } gd_topal.c, PHP 4.3.7, lines 733-748 ------------------------------------- #ifdef ORIGINAL_LIB_JPEG cinfo->colormap[0][icolor] = (JSAMPLE) ((c0total + (total >> 1)) / total); cinfo->colormap[1][icolor] = (JSAMPLE) ((c1total + (total >> 1)) / total); cinfo->colormap[2][icolor] = (JSAMPLE) ((c2total + (total >> 1)) / total); #else /* 2.0.16: Paul den Dulk found an occasion where total can be 0 */ if (count) { im->red[icolor] = (int) ((c0total + (total >> 1)) / total); im->green[icolor] = (int) ((c1total + (total >> 1)) / total); im->blue[icolor] = (int) ((c2total + (total >> 1)) / total); } else { im->red[icolor] = 255; im->green[icolor] = 255; im->blue[icolor] = 255; } #endif ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/28949 -- Edit this bug report at http://bugs.php.net/?id=28949&edit=1