#29711 [Fbk]: libxml and non iso-8859-1

ID: 29711 Updated by: derick@php.net Reported By: momo@php.net Status: Feedback Bug Type: XML related Operating System: ALL PHP Version: 5.0.1 New Comment: Right, let's do that. I can try to make a patch if somebody can send me an example script (in a .tar.gz file). Previous Comments: ------------------------------------------------------------------------ [2004-08-18 10:09:36] rasmus@php.net We are still early enough in PHP5 deployment to fix stuff like this and not worry too much about 5.0.x BC breakage. Especially for something which already has broken BC with PHP4. People porting their stuff are already screwed. So we either revert to PHP4 behaviour to remove the BC break or we do it right and default to UTF-8. Leaving it as-is because of BC worries to 5.0.x shouldn't even be considered. My vote is to default it to UTF-8. ------------------------------------------------------------------------ [2004-08-17 09:15:32] momo@php.net the minimun BC 'll be convert it back to the orginal encoding by default, it'll not break any php4 or php5 scripts, it'll break only the not working one, what the problem with it? ------------------------------------------------------------------------ [2004-08-17 08:58:46] derick@php.net Oh come on, nobody uses PHP 5 yet :) For once do things right instead of half-assed solutions we've had for the past years because of BC issues. ------------------------------------------------------------------------ [2004-08-17 08:51:03] chregu@php.net It works for all correctly, which use iso-8859-1 (or similar or utf-8 in the iso-8859-1 space) source encoding or which did specify utf-8 as output encoding. So for the majority (I'd say), it works as expected, if we change default to UTF-8 (which would be of course the correct solution), it will break a lot of people's code. The encoding thingie in ext/xml in PHP 4 was always broken, IMHO. We unfortunately missed the chance to implement it more correctly with slight BC breaks for PHP 5.0.0... ------------------------------------------------------------------------ [2004-08-17 08:28:58] derick@php.net I'm for breaking it and make it output UTF-8 by default like the domxml stuff does. Consistency is a good thing and as it doesn't work "correctly" for 5.0.0 and 5.0.1 anyway I'd say we fix this. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/29711 -- Edit this bug report at http://bugs.php.net/?id=29711&edit=1