#30685 [NEW]: Malformed SOAPClient http header reequest

From: Date: Thu, 04 Nov 2004 14:16:22 +0000
Subject: #30685 [NEW]: Malformed SOAPClient http header reequest
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-68694@lists.php.net to get a copy of this message
From:             lagoni at dsw dot dk
Operating system: Fedora Core 2
PHP version:      5.0.2
PHP Bug Type:     SOAP related
Bug description:  Malformed SOAPClient http header reequest

Description:
------------
Description:
------------
I found a error in the implementation of the http header in the SOAP
extension.
The error also exist in the newest CVS version.

According to the HTTP 1.1 RFC2616, section 3.4:

“HTTP character sets are identified by case-insensitive tokens. The
complete set of tokens is defined by the IANA Character Set registry[19].

          charset = token
“
The extension is wrapping double quotes around the torken of the charset
tag.

I tried to patch it, and it seems to work:

--- php_http.c.orig	2004-06-22 14:42:17.000000000 +0200
+++ php_http.c	2004-11-04 15:02:48.588726799 +0100
@@ -390,14 +390,14 @@
 */
 			"User-Agent: PHP SOAP 0.1\r\n");
 		if (soap_version == SOAP_1_2) {
-			smart_str_append_const(&soap_headers,"Content-Type:
application/soap+xml; charset=\"utf-8");
+			smart_str_append_const(&soap_headers,"Content-Type:
application/soap+xml; charset=utf-8");
 			if (soapaction) {
 				smart_str_append_const(&soap_headers,"\"; action=\"");
 				smart_str_appends(&soap_headers, soapaction);
 			}
 			smart_str_append_const(&soap_headers,"\"\r\n");
 		} else {
-			smart_str_append_const(&soap_headers,"Content-Type: text/xml;
charset=\"utf-8\"\r\n");
+			smart_str_append_const(&soap_headers,"Content-Type: text/xml;
charset=utf-8\r\n");
 			if (soapaction) {
 				smart_str_append_const(&soap_headers, "SOAPAction: \"");
 				smart_str_appends(&soap_headers, soapaction);



-- 
Edit bug report at http://bugs.php.net/?id=30685&edit=1
-- 
Try a CVS snapshot (php4):   http://bugs.php.net/fix.php?id=30685&r=trysnapshot4
Try a CVS snapshot (php5.0): http://bugs.php.net/fix.php?id=30685&r=trysnapshot50
Try a CVS snapshot (php5.1): http://bugs.php.net/fix.php?id=30685&r=trysnapshot51
Fixed in CVS:                http://bugs.php.net/fix.php?id=30685&r=fixedcvs
Fixed in release:            http://bugs.php.net/fix.php?id=30685&r=alreadyfixed
Need backtrace:              http://bugs.php.net/fix.php?id=30685&r=needtrace
Need Reproduce Script:       http://bugs.php.net/fix.php?id=30685&r=needscript
Try newer version:           http://bugs.php.net/fix.php?id=30685&r=oldversion
Not developer issue:         http://bugs.php.net/fix.php?id=30685&r=support
Expected behavior:           http://bugs.php.net/fix.php?id=30685&r=notwrong
Not enough info:             http://bugs.php.net/fix.php?id=30685&r=notenoughinfo
Submitted twice:             http://bugs.php.net/fix.php?id=30685&r=submittedtwice
register_globals:            http://bugs.php.net/fix.php?id=30685&r=globals
PHP 3 support discontinued:  http://bugs.php.net/fix.php?id=30685&r=php3
Daylight Savings:            http://bugs.php.net/fix.php?id=30685&r=dst
IIS Stability:               http://bugs.php.net/fix.php?id=30685&r=isapi
Install GNU Sed:             http://bugs.php.net/fix.php?id=30685&r=gnused
Floating point limitations:  http://bugs.php.net/fix.php?id=30685&r=float
MySQL Configuration Error:   http://bugs.php.net/fix.php?id=30685&r=mysqlcfg


Thread (3 messages)

« previous php.bugs (#68694) next »