#31121 [Opn->Fbk]: Compilation fails on zend_strtod.c

ID: 31121 Updated by: sniper@php.net Reported By: strube at physik3 dot gwdg dot de -Status: Open +Status: Feedback Bug Type: Compile Failure Operating System: Solaris 7 SPARC PHP Version: 4.3.10 Assigned To: derick New Comment: I didn't ask you to look if some file is same as it was before. I asked you to try the fresh snapshot. So did it compile or not? Previous Comments: ------------------------------------------------------------------------ [2004-12-22 09:48:08] strube at physik3 dot gwdg dot de > Please try using this CVS snapshot: > http://snaps.php.net/php4-STABLE-latest.tar.gz Therein (=php4-STABLE-200412171130), zend_strtod.c is no different from the one in 200412210730 I tested previously. > And you're wrong about WORDS_BIGENDIAN. It will NOT be > defined at all on a system which is not big-endian. Sorry, you are right. I did not actually configure in x86 but concluded this from the php_config.h in the official 4.3.10 release, containing #define WORDS_BIGENDIAN 1. In the present snapshots, it is defined without value. ------------------------------------------------------------------------ [2004-12-22 00:46:35] sniper@php.net And you're wrong about WORDS_BIGENDIAN. It will NOT be defined at all on a system which is not big-endian. (not to 0 or not to 1) ------------------------------------------------------------------------ [2004-12-22 00:45:14] sniper@php.net Please try using this CVS snapshot: http://snaps.php.net/php4-STABLE-latest.tar.gz For Windows: http://snaps.php.net/win32/php4-win32-STABLE-latest.zip Try again. ------------------------------------------------------------------------ [2004-12-21 10:51:54] strube at physik3 dot gwdg dot de I tested compiling zend_strtod.c from php4-STABLE-200412210730 in Solaris 7 SPARC and Solaris 9_x86 with Sun cc and gcc. All compilations succeed, but in x86, still IEEE_BIG_ENDIAN is erroneously defined. Fix line 104: #ifdef WORDS_BIGENDIAN must be #if WORDS_BIGENDIAN because it is either 1 or 0. Also, on those architectures for which subsequent #define IEEE_..._ENDIAN occur (lines 116 and 126; not in Solaris), there will be warnings or errors concerning redefinition of IEEE_..._ENDIAN (not in Solaris) or failure in the test of line 226 due to definition of both IEEE_{BIG,LITTLE}_ENDIAN. I cannot test on those architectures myself. ------------------------------------------------------------------------ [2004-12-21 05:53:56] sniper@php.net Please try using this CVS snapshot: http://snaps.php.net/php4-STABLE-latest.tar.gz For Windows: http://snaps.php.net/win32/php4-win32-STABLE-latest.zip ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/31121 -- Edit this bug report at http://bugs.php.net/?id=31121&edit=1