#31261 [Opn->Bgs]: strange fix of old mysql LOAD DATA LOCAL INFILE issue

ID: 31261 Updated by: iliaa@php.net Reported By: dev at jkt dot wz dot cz -Status: Open +Status: Bogus Bug Type: MySQL related Operating System: all PHP Version: 4.3.10 New Comment: This is a non issue, the code avoids touching the mask if there is nothing to change in it. Previous Comments: ------------------------------------------------------------------------ [2004-12-22 23:41:33] dev at jkt dot wz dot cz Description: ------------ Hi, sorry for creating another useless bugreport, but I haven't ability to comment bugs in CLOSED state. [Considering bug reports #23779 and #28632 and mainly lines 601-604 in ext/mysql/php_mysql.c] /* disable local infile option for open_basedir */ if (PG(open_basedir) && strlen(PG(open_basedir)) && (client_flags & CLIENT_LOCAL_FILES)) { client_flags ^= CLIENT_LOCAL_FILES; } Are you, PHP developers, sure that the approach "So, let's check bit 7. Oh, it is set, uhm, so, let's read it, make a negation and the write it back" the best way? Shouldn't be better (and also more elegant, faster,...) to write something like: if (PG(open_basedir) && strlen(open_basedir)) { client_flags &= ~CLIENT_LOCAL_FILES; } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=31261&edit=1