#31710 [Asn->Csd]: return value of rollback() is inverted

ID: 31710 Updated by: georg@php.net Reported By: cyrilleml at kbuilder dot net -Status: Assigned +Status: Closed Bug Type: MySQLi related Operating System: winXP Pro PHP Version: 5.0.3 Assigned To: georg New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2005-01-26 23:59:01] tony2001@php.net Assigning to Georg. According to MySQL docs, mysql_autocommit(), mysql_commit() & mysql_rollback() return 0 on success and non-zero value on error and using RETURN_BOOL(result_value) here is obviously wrong. ------------------------------------------------------------------------ [2005-01-26 23:17:57] cyrilleml at kbuilder dot net Description: ------------ Hello, Functions rollback() works fine expected that the return value is inverted. if rollback() failed, return value is TRUE, if rollback() success, return value is FALSE. The problem is that the Documentation say the opposite. So for my code work fine, I've to write: if( $dbh1->rollback() ){ printf( "DBH1 Failed to rollback : %s \n", $dbh1->error); } bye cyrille Reproduce code: --------------- if( $dbh1->rollback() ){ printf( "DBH1 Failed to rollback : %s \n", $dbh1->error); } Expected result: ---------------- if( ! $dbh1->rollback() ){ printf( "DBH1 Failed to rollback : %s \n", $dbh1->error); } or if( $dbh1->rollback() == FALSE ){ printf( "DBH1 Failed to rollback : %s \n", $dbh1->error); } ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=31710&edit=1