#32624 [Opn->Csd]: Rephrase: "Please allow this report to be send to the PHP QA team."

ID: 32624 Updated by: sniper@php.net Reported By: php-bugs-2005 at ryandesign dot com -Status: Open +Status: Closed Bug Type: Compile Warning Operating System: N/A PHP Version: 5.0.4 New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2005-04-07 18:33:23] php-bugs-2005 at ryandesign dot com Oh, very well. :-) http://test.michel-consulting.de/ryan/php-5.0.4-failed- test-message.patch ------------------------------------------------------------------------ [2005-04-07 17:53:58] sniper@php.net Could you please be so kind and provide a patch? (for run-tests.php) ------------------------------------------------------------------------ [2005-04-07 16:17:35] php-bugs-2005 at ryandesign dot com Description: ------------ In ./run-tests.php and ./server-tests.php the following message can be displayed: > Please allow this report to be send to the PHP QA > team. This will give us a better understanding in how > PHP's test cases are doing. There are a number of problems with this message. For one thing, it should be "sent" and not "send," and I think "understanding of how" is better than "understanding in how." The fundamental problem though is made obvious by the prompt that follows it: > (choose "s" to just save the results to a file)? > [Yns]: See, there's a question mark, and it expects a "yes" or "no" (or "save") answer. I would therefore reformulate it as a question. The message also seems to appear without any explanation to the user. It could be made friendlier. Suggestion below. This problem is presumably also present in PHP4. Reproduce code: --------------- N/A Expected result: ---------------- You may have found a problem in PHP's test cases. We'd like to automatically send this report to the PHP QA team, to give us a better understanding of how the test cases are doing. If you don't want to send it immediately, you can choose "s" to save the report to a file that you can send us later. May we send this report now? [Yns]: Actual result: -------------- Please allow this report to be send to the PHP QA team. This will give us a better understanding in how PHP's test cases are doing. (choose "s" to just save the results to a file)? [Yns]: ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=32624&edit=1