#31772 [Opn]: [PATCH] Net-SNMP 5.2.x ++ Workaround in PHP_SNMP Incorrectly Coded

From: Date: Tue, 01 Mar 2005 00:24:54 +0000
Subject: #31772 [Opn]: [PATCH] Net-SNMP 5.2.x ++ Workaround in PHP_SNMP Incorrectly Coded
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-77348@lists.php.net to get a copy of this message
 ID:               31772
 User updated by:  LarryJAdams at comcast dot net
 Reported By:      LarryJAdams at comcast dot net
 Status:           Open
 Bug Type:         SNMP related
 Operating System: Win32
 PHP Version:      5.0.3
 New Comment:

The prior post was for the snmp.c files.  The php_snmp.h files are
patched as follows:

php_snmp.h for php4.3.x
http://home.comcast.net/~larryjadams/php_snmp.4.3.x.diff

php_snmp.h for php5.0.x
http://home.comcast.net/~larryjadams/php_snmp.5.0.x.diff

php_snmp.h for php5.1.x
http://home.comcast.net/~larryjadams/php_snmp.5.1.x.diff

TheWitness


Previous Comments:
------------------------------------------------------------------------

[2005-03-01 00:52:58] LarryJAdams at comcast dot net

Your links are as follows:

php_snmp for php4.3.x
http://home.comcast.net/~larryjadams/snmp4.3.x.diff

php_snmp for php5.0.x
http://home.comcast.net/~larryjadams/snmp5.0.x.diff

php_snmp for php5.1.x
http://home.comcast.net/~larryjadams/snmp5.1.x.diff

TheWitness

------------------------------------------------------------------------

[2005-02-28 20:54:38] sniper@php.net

Please provide the unified diff somewhere in the web and add the url to
it here.


------------------------------------------------------------------------

[2005-02-01 03:17:57] larryjadams at comcast dot net

I have submitted fixes for the following PHP CVS Branches:

PHP 4.3.x
PHP 5.0.x
PHP 5.1.x

The fix also included the snmpv2 feature set.  I hope you all enjoy it
as much as I will.

Larry

------------------------------------------------------------------------

[2005-01-31 01:05:46] LarryJAdams at comcast dot net

Description:
------------
The following code in snmp.c from lines: 794 through 831 is not valid. 
If both HAVE_AES and SNMP_VALIDATE_ERR are defined, the ifdef's will not
function properly.  Please review the code below.

Reproduce code:
---------------
Incorrect code (starting on 810):

"* symbol on purpose, as it's defined to be the same as the former.
*/
			|| !strcasecmp(prot, "AES")) {
#else			
		) {
			s->securityPrivProto = usmAES128PrivProtocol;
			s->securityPrivProtoLen = OIDSIZE(usmAES128PrivProtocol);
			return (0);"


Correct Code (starting on 810):

"* symbol on purpose, as it's defined to be the same as the former.
*/
			|| !strcasecmp(prot, "AES")) {
			s->securityPrivProto = usmAES128PrivProtocol;
			s->securityPrivProtoLen = OIDSIZE(usmAES128PrivProtocol);
			return (0);
#else			
		) {
			s->securityPrivProto = usmAES128PrivProtocol;
			s->securityPrivProtoLen = OIDSIZE(usmAES128PrivProtocol);
			return (0);"


Expected result:
----------------
N/A.  Please review code snippet.

Actual result:
--------------
N/A.  Please review code snippet.


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=31772&edit=1


Thread (12 messages)

« previous php.bugs (#77348) next »