#32773 [Opn->Asn]: binary GMP functions returns unexpected value, when second parameter is int(0)

ID: 32773 Updated by: tony2001@php.net Reported By: valyala at gmail dot com -Status: Open +Status: Assigned Bug Type: Math related Operating System: unix PHP Version: 5.0.4 -Assigned To: +Assigned To: stas New Comment: Assigning to the maintainer. Previous Comments: ------------------------------------------------------------------------ [2005-04-19 22:32:25] valyala at gmail dot com Description: ------------ All binary functions from GMP extension return FALSE insted of expected value, when zero is passed as second parameter. I noticed the following piece of code in two places of ext/gmp/gmp.c file, which purpose I couldn't understand: if (!Z_LVAL_PP(b_arg)) { RETURN_FALSE; } This code returns FALSE, when second parameter of binary GMP function equals to zero. I tried to delete this code from ext/gmp/gmp.c , and it seems that all work nice after that. Here is unified diff: ----------cut---------- --- gmp_old.c Tue Apr 19 23:18:06 2005 +++ gmp.c Tue Apr 19 23:18:28 2005 @@ -312,10 +312,6 @@ FETCH_GMP_ZVAL(gmpnum_b, b_arg); } - if (!Z_LVAL_PP(b_arg)) { - RETURN_FALSE; - } - INIT_GMP_NUM(gmpnum_result); if (use_ui && gmp_ui_op) { @@ -355,10 +351,6 @@ use_ui = 1; } else { FETCH_GMP_ZVAL(gmpnum_b, b_arg); - } - - if (!Z_LVAL_PP(b_arg)) { - RETURN_FALSE; } INIT_GMP_NUM(gmpnum_result1); ----------cut---------- Reproduce code: --------------- <? // all binary functions from GMP extension // return FALSE insted of expected value, // when zero is passed as second parameter. echo '10 + 0 = ', gmp_strval(gmp_add(10, 0)), "\n"; // normal behaviour. Just convert zero into string echo '10 + "0" = ', gmp_strval(gmp_add(10, '0')), "\n"; ?> Expected result: ---------------- 10 + 0 = 10 10 + 0 = 10 Actual result: -------------- 10 + 0 = 0 10 + 0 = 10 ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=32773&edit=1